[lib] Include the rawChatName when constructing the chat mention search index
ClosedPublic
Actions

Authored by rohan on Dec 26 2023, 10:02 AM.

Details

Reviewers

atul
ginsu
inka

Commits

rCOMM610946adb4c4: [lib] Include the rawChatName when constructing the chat mention search index

Summary

This diff is the final one in the stack. It allows us to actually @-mention a chat with ENS users with a cleared name by the member's wallet addresses. This is done in the same way we construct our search indexes for users - we take all possible search terms into an array for the thread ID and then join them by a space. For reference, here is the code for the user search index.

Part of ENG-5436

Depends on D10460

Test Plan

Please see the videos below where I can now @-mention the chat both by ENS name and wallet addresses.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Dec 26 2023, 10:02 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 26 2023, 10:02 AM

rohan edited the test plan for this revision. (Show Details)Dec 26 2023, 10:03 AM

rohan edited the test plan for this revision. (Show Details)Dec 26 2023, 10:28 AM

Harbormaster completed remote builds in B25339: Diff 35008.Dec 26 2023, 10:47 AM

rohan requested review of this revision.Dec 26 2023, 10:47 AM

inka accepted this revision.Dec 28 2023, 4:25 AM

This revision is now accepted and ready to land.Dec 28 2023, 4:25 AM

Rebase

Harbormaster completed remote builds in B25373: Diff 35052.Dec 28 2023, 9:30 AM

Closed by commit rCOMM610946adb4c4: [lib] Include the rawChatName when constructing the chat mention search index (authored by rohan). · Explain WhyDec 29 2023, 8:14 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM610946adb4c4: [lib] Include the rawChatName when constructing the chat mention search index.

Revision Contents
Changeset List

Path

Size

lib/

components/

chat-mention-provider.react.js

14 lines

utils/

entity-text.js

1 line

Diff 35095

View Options

lib/components/chat-mention-provider.react.js

Show All 19 Lines	export type OutboundP2PMessageStatuses = $Values<
typeof outboundP2PMessageStatuses,		typeof outboundP2PMessageStatuses,
>;		>;

export type InboundP2PMessage = {		export type InboundP2PMessage = {
+messageID: string,		+messageID: string,
+senderDeviceID: string,		+senderDeviceID: string,
+plaintext: string,		+plaintext: string,
+status: string,		+status: string,
		+senderUserID: string,
};		};

export type OutboundP2PMessage = {		export type OutboundP2PMessage = {
+messageID: string,		+messageID: string,
+deviceID: string,		+deviceID: string,
+userID: string,		+userID: string,
+timestamp: string,		+timestamp: string,
+plaintext: string,		+plaintext: string,
▲ Show 20 Lines • Show All 41 Lines • Show Last 20 Lines