[lib] Rename threadInfos to resolvedThreadInfos in getChatMentionCandidates
ClosedPublic
Actions

Authored by rohan on Dec 26 2023, 9:46 AM.

Details

Reviewers

atul
ginsu
inka
ashoat

Commits

rCOMM87b294ac9410: [lib] Rename threadInfos to resolvedThreadInfos in getChatMentionCandidates

Summary

Just a quick rename diff to make it clear that the thread infos passed in are resolved. I'm doing this because the following diffs will involve passing in the unresolved ThreadInfos as a parameter alongside the resolved thread infos.

Part of ENG-5436

Test Plan

Ran flow to confirm no errors

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Dec 26 2023, 9:46 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 26 2023, 9:46 AM

rohan added a child revision: D10459: [lib] Pass in threadInfos into getChatMentionCandidates.Dec 26 2023, 9:48 AM

Fix type for resolvedThreadInfos

Harbormaster completed remote builds in B25334: Diff 35003.Dec 26 2023, 10:06 AM

Harbormaster completed remote builds in B25336: Diff 35005.Dec 26 2023, 10:38 AM

rohan requested review of this revision.Dec 26 2023, 10:38 AM

ashoat accepted this revision.Dec 26 2023, 10:44 AM

This revision is now accepted and ready to land.Dec 26 2023, 10:44 AM

Closed by commit rCOMM87b294ac9410: [lib] Rename threadInfos to resolvedThreadInfos in getChatMentionCandidates (authored by rohan). · Explain WhyDec 29 2023, 8:14 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMM87b294ac9410: [lib] Rename threadInfos to resolvedThreadInfos in getChatMentionCandidates.

Revision Contents
Changeset List

Path

Size

lib/

components/

chat-mention-provider.react.js

30 lines

Diff 35092

View Options

lib/components/chat-mention-provider.react.js

[lib] Rename threadInfos to resolvedThreadInfos in getChatMentionCandidatesClosedPublicActions