Page MenuHomePhabricator
Differential D10458

[lib] Rename threadInfos to resolvedThreadInfos in getChatMentionCandidates
ClosedPublic
Actions

Authored by rohan on Dec 26 2023, 9:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Mar 19, 4:21 AM
Unknown Object (File)
Wed, Mar 5, 8:15 AM
Unknown Object (File)
Wed, Mar 5, 6:40 AM
Unknown Object (File)
Wed, Mar 5, 6:39 AM
Unknown Object (File)
Wed, Mar 5, 6:39 AM
Unknown Object (File)
Wed, Mar 5, 6:39 AM
Unknown Object (File)
Wed, Mar 5, 6:39 AM
Unknown Object (File)
Mon, Feb 24, 3:20 PM
View All 69 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ginsu
inka
ashoat
Commits
rCOMM87b294ac9410: [lib] Rename threadInfos to resolvedThreadInfos in getChatMentionCandidates
Summary

Just a quick rename diff to make it clear that the thread infos passed in are resolved. I'm doing this because the following diffs will involve passing in the unresolved ThreadInfos as a parameter alongside the resolved thread infos.

Part of ENG-5436

Test Plan

Ran flow to confirm no errors

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
components/
30 lines

Diff 35092

View Options

lib/components/chat-mention-provider.react.js

  • This file was added.
.container {
display: flex;
flex-direction: column;
row-gap: 18px;
padding: 16px 12px;
overflow-y: scroll;
flex: 1;
}