Page MenuHomePhabricator
Differential D10459

[lib] Pass in threadInfos into getChatMentionCandidates
ClosedPublic
Actions

Authored by rohan on Dec 26 2023, 9:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Mar 15, 5:31 PM
Unknown Object (File)
Sat, Mar 15, 12:23 AM
Unknown Object (File)
Thu, Mar 13, 5:53 AM
Unknown Object (File)
Thu, Mar 13, 3:05 AM
Unknown Object (File)
Wed, Mar 12, 10:11 PM
Unknown Object (File)
Wed, Mar 12, 1:11 AM
Unknown Object (File)
Tue, Mar 11, 10:41 AM
Unknown Object (File)
Sat, Mar 8, 4:00 AM
View All 77 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
ginsu
inka
ashoat
Commits
rCOMMf0db11d1b4e7: [lib] Pass in threadInfos into getChatMentionCandidates
Summary

Small diff to just pass in threadInfos into getChatMentionCandidates, since the next diff will use it. The next diff has a lot of changes to deal with Flow, so I thought separating this small change into its own diff made sense. If the reviewers disagree, I'm happy to merge this with the diff that uses threadInfos.

Part of ENG-5436

Depends on D10458

Test Plan

Ran flow again since there are no real changes to test here

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
lib/
components/
11 lines

Diff 35093

View Options

lib/components/chat-mention-provider.react.js

Show First 20 Lines • Show All 156 Lines • ▼ Show 20 Linesdeclare export class KeyserverKeysResponse extends Message {
hasKeyserverInfo(): boolean; hasKeyserverInfo(): boolean;
clearKeyserverInfo(): KeyserverKeysResponse; clearKeyserverInfo(): KeyserverKeysResponse;
getIdentity(): Identity | void; getIdentity(): Identity | void;
setIdentity(value?: Identity): KeyserverKeysResponse; setIdentity(value?: Identity): KeyserverKeysResponse;
hasIdentity(): boolean; hasIdentity(): boolean;
clearIdentity(): KeyserverKeysResponse; clearIdentity(): KeyserverKeysResponse;
getPrimaryDeviceIdentityInfo(): identityStructs.IdentityKeyInfo | void;
setPrimaryDeviceIdentityInfo(value?: identityStructs.IdentityKeyInfo): KeyserverKeysResponse;
hasPrimaryDeviceIdentityInfo(): boolean;
clearPrimaryDeviceIdentityInfo(): KeyserverKeysResponse;
serializeBinary(): Uint8Array; serializeBinary(): Uint8Array;
toObject(includeInstance?: boolean): KeyserverKeysResponseObject; toObject(includeInstance?: boolean): KeyserverKeysResponseObject;
static toObject(includeInstance: boolean, msg: KeyserverKeysResponse): KeyserverKeysResponseObject; static toObject(includeInstance: boolean, msg: KeyserverKeysResponse): KeyserverKeysResponseObject;
static serializeBinaryToWriter(message: KeyserverKeysResponse, writer: BinaryWriter): void; static serializeBinaryToWriter(message: KeyserverKeysResponse, writer: BinaryWriter): void;
static deserializeBinary(bytes: Uint8Array): KeyserverKeysResponse; static deserializeBinary(bytes: Uint8Array): KeyserverKeysResponse;
static deserializeBinaryFromReader(message: KeyserverKeysResponse, reader: BinaryReader): KeyserverKeysResponse; static deserializeBinaryFromReader(message: KeyserverKeysResponse, reader: BinaryReader): KeyserverKeysResponse;
} }
export type KeyserverKeysResponseObject = { export type KeyserverKeysResponseObject = {
keyserverInfo: ?OutboundKeyInfoObject, keyserverInfo: ?OutboundKeyInfoObject,
identity: ?IdentityObject, identity: ?IdentityObject,
primaryDeviceIdentityInfo: ?identityStructs.IdentityKeyInfoObject,
}; };
declare export class OutboundKeysForUserResponse extends Message { declare export class OutboundKeysForUserResponse extends Message {
getDevicesMap(): ProtoMap<string, OutboundKeyInfo>; getDevicesMap(): ProtoMap<string, OutboundKeyInfo>;
clearDevicesMap(): OutboundKeysForUserResponse; clearDevicesMap(): OutboundKeysForUserResponse;
serializeBinary(): Uint8Array; serializeBinary(): Uint8Array;
toObject(includeInstance?: boolean): OutboundKeysForUserResponseObject; toObject(includeInstance?: boolean): OutboundKeysForUserResponseObject;
▲ Show 20 Lines • Show All 537 Lines • Show Last 20 Lines