Page MenuHomePhabricator

[web] update colors in app directory modal to use enum option color family
ClosedPublic

Authored by ginsu on Dec 29 2023, 11:47 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 5, 9:29 PM
Unknown Object (File)
Oct 31 2024, 3:52 AM
Unknown Object (File)
Oct 3 2024, 12:17 PM
Unknown Object (File)
Oct 3 2024, 12:17 PM
Unknown Object (File)
Oct 3 2024, 12:17 PM
Unknown Object (File)
Oct 3 2024, 12:17 PM
Unknown Object (File)
Oct 3 2024, 12:17 PM
Unknown Object (File)
Sep 17 2024, 10:36 AM
Subscribers

Details

Summary

As I was working on the web app redesign I took a more critical look at the button color family. I found one variant of the button color family (--button-background-tetriary-default) where it was being used in a situation that seemed to better fit the enum option color family. This diff moves that button color family variant into a new enum option color family variant.

For context this is where --button-background-tetriary-default was being used:

Screenshot 2023-12-29 at 2.49.56 PM.png (2×3 px, 882 KB)

To me this is more of an "enum option" element type

Test Plan

Confirmed that the app directory modal which used this color family variant looks exactly the same as before

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Dec 29 2023, 1:48 PM
This revision was landed with ongoing or failed builds.Dec 29 2023, 2:42 PM
This revision was automatically updated to reflect the committed changes.