[web] introduce community header actions
ClosedPublic
Actions

Authored by ginsu on Dec 29 2023, 12:18 PM.

Details

Reviewers

atul
kamil
rohan

Commits

rCOMM91e90f292e22: [web] introduce community header actions

Summary

This component houses the invite link button and the community settings button, two possible community action buttons that can be rendered, and all the related logic for that. If a community does not have an active invite link then the invite link button should not be rendered.

The invite link button should push the ViewInviteLinkModal and the community settings button will navigate the user to the community settings screen (will be done in a subsequent diff)

Linear task: https://linear.app/comm/issue/ENG-5933/top-bar

Depends on D10497

Test Plan

Please see the screenshots + demo video below

When the community has an active invite link

When the community does not have an active invite link

Screenshot 2023-12-29 at 3.27.25 PM.png (1×3 px, 868 KB)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 29 2023, 12:18 PM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 29 2023, 12:18 PM

ginsu edited the summary of this revision. (Show Details)Dec 29 2023, 12:27 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, kamil, rohan.

ginsu attached a referenced file: F1013676: Screenshot 2023-12-29 at 3.27.25 PM.png. (Show Details)

ginsu added inline comments.

web/community-header/community-header-actions.react.js
36 ↗	(On Diff #35108)	This will be worked on in January

ginsu added a child revision: D10499: [web] introduce community header.Dec 29 2023, 12:41 PM

ginsu edited the summary of this revision. (Show Details)

ginsu added a parent revision: D10497: [web] introduce community header button.

Harbormaster completed remote builds in B25409: Diff 35108.Dec 29 2023, 12:42 PM

ginsu requested review of this revision.Dec 29 2023, 12:42 PM

Maybe I'm missing something, but it looks like the message list is missing in the screenshots provided. Guessing this was just for debugging layout or something?

web/community-header/community-header-actions.react.js
53–62 ↗	(On Diff #35108)	Wouldn't hurt to memoize this

This revision is now accepted and ready to land.Dec 30 2023, 2:41 AM

address comments + rebase before landing

Maybe I'm missing something, but it looks like the message list is missing in the screenshots provided. Guessing this was just for debugging layout or something?

Yea I was dealing with some layout issues earlier, and the message list was outside the scope of this diff but here's a better screenshot: