Page MenuHomePhabricator
Differential D10363

[web] introduce community creation button for navigation sidebar
ClosedPublic
Actions

Authored by ginsu on Dec 15 2023, 1:26 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 18, 1:28 AM
Unknown Object (File)
Thu, Oct 31, 12:25 AM
Unknown Object (File)
Thu, Oct 31, 12:25 AM
Unknown Object (File)
Thu, Oct 31, 12:25 AM
Unknown Object (File)
Thu, Oct 31, 12:25 AM
Unknown Object (File)
Thu, Oct 31, 12:25 AM
Unknown Object (File)
Oct 3 2024, 11:09 AM
Unknown Object (File)
Sep 17 2024, 10:13 AM
View All 59 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMM52a3ee34cbac: [web] introduce community creation button for navigation sidebar
Summary

This diff introduces the community creation button that will be rendered in the navigation sidebar footer

linear task: https://linear.app/comm/issue/ENG-5930/community-sidebar

Depends on D10362

Test Plan

Please see the demo video below:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 15 2023, 1:26 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 15 2023, 1:26 PM
ginsu edited the summary of this revision. (Show Details)Dec 15 2023, 1:28 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
ginsu added a parent revision: D10362: [web] introduce account settings button for navigation sidebar.
ginsu added a child revision: D10364: [web] introduce navigation sidebar.Dec 15 2023, 1:34 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 15 2023, 2:05 PM
Harbormaster failed remote builds in B25140: Diff 34750!
ginsu requested review of this revision.Dec 15 2023, 2:09 PM

will make sure ci passes before landing

rohan accepted this revision.Dec 18 2023, 1:59 PM
rohan added inline comments.
web/navigation-sidebar/community-creation-button.react.js
15–17 ↗(On Diff #34750)

This should work

This revision is now accepted and ready to land.Dec 18 2023, 1:59 PM
ginsu updated this revision to Diff 34936.Dec 21 2023, 3:05 PM

address comments + rebase before landing

Harbormaster completed remote builds in B25299: Diff 34936.Dec 21 2023, 4:16 PM
Closed by commit rCOMM52a3ee34cbac: [web] introduce community creation button for navigation sidebar (authored by ginsu). · Explain WhyDec 21 2023, 4:41 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM52a3ee34cbac: [web] introduce community creation button for navigation sidebar.

Revision Contents
Changeset List

PathSize
web/
navigation-sidebar/
14 lines
36 lines

Diff 34944

View Options

web/navigation-sidebar/community-creation-button.css

Loading...
View Options

web/navigation-sidebar/community-creation-button.react.js

Loading...