Details

Reviewers

atul
rohan
kamil

Commits

rCOMM8f76b89da5cd: [lib] introduce unreadCountSelectorForCommunity

Summary

This diff introduces a new selector that given a the id of a community it will return the unread count for that community. This diff should also address some feedback I got in D10393

Depends on D10391

Test Plan

Confirmed that I was getting the correct unread count for each community in my new nav sidebar

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 22 2023, 2:36 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 22 2023, 2:36 AM

ginsu edited the summary of this revision. (Show Details)Dec 22 2023, 2:37 AM

ginsu added reviewers: atul, rohan, kamil.

ginsu added a parent revision: D10391: [web] show total unreads in the navigation sidebar home button.

ginsu added a child revision: D10393: [web] show unreads for each community in the community list.

ginsu mentioned this in D10393: [web] show unreads for each community in the community list.

Harbormaster completed remote builds in B25305: Diff 34950.Dec 22 2023, 2:55 AM

ginsu requested review of this revision.Dec 22 2023, 2:55 AM

atul accepted this revision.Dec 27 2023, 1:13 AM

This revision is now accepted and ready to land.Dec 27 2023, 1:13 AM

rebasee before landing

This revision was landed with ongoing or failed builds.Dec 27 2023, 8:31 PM

Closed by commit rCOMM8f76b89da5cd: [lib] introduce unreadCountSelectorForCommunity. · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM8f76b89da5cd: [lib] introduce unreadCountSelectorForCommunity.

Harbormaster completed remote builds in B25352: Diff 35026.Dec 27 2023, 8:46 PM

[lib] introduce unreadCountSelectorForCommunity
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 35028

lib/selectors/thread-selectors.js

[lib] introduce unreadCountSelectorForCommunityClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35028

lib/selectors/thread-selectors.js

[lib] introduce unreadCountSelectorForCommunity
ClosedPublic
Actions

Revision Contents
Changeset List