Page MenuHomePhabricator
Differential D10364

[web] introduce navigation sidebar
ClosedPublic
Actions

Authored by ginsu on Dec 15 2023, 1:31 PM.
Tags
None
Referenced Files
F3500331: D10364.id34751.diff
Fri, Dec 20, 1:15 AM
F3496982: D10364.id.diff
Thu, Dec 19, 4:45 PM
Unknown Object (File)
Mon, Dec 16, 7:53 AM
Unknown Object (File)
Nov 7 2024, 10:13 AM
Unknown Object (File)
Oct 31 2024, 12:25 AM
Unknown Object (File)
Oct 31 2024, 12:25 AM
Unknown Object (File)
Oct 31 2024, 12:25 AM
Unknown Object (File)
Oct 31 2024, 12:25 AM
View All 78 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMM963e77822c17: [web] introduce navigation sidebar
Summary

After introducing all the parts for the navigation sidebar, this diff introduces the navigation sidebar component that brings all the buttons + community list together in one component

linear task: https://linear.app/comm/issue/ENG-5930/community-sidebar

Depends on D10363

Test Plan

Please see screenshot below

Screenshot 2023-12-15 at 4.33.44 PM.png (1×196 px, 30 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 15 2023, 1:31 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 15 2023, 1:31 PM
ginsu edited the summary of this revision. (Show Details)Dec 15 2023, 1:34 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, rohan, kamil.
ginsu added a parent revision: D10363: [web] introduce community creation button for navigation sidebar.
ginsu updated this revision to Diff 34752.Dec 15 2023, 1:38 PM

update

ginsu attached a referenced file: F955109: Screenshot 2023-12-15 at 4.33.44 PM.png. (Show Details)Dec 15 2023, 1:38 PM
Harbormaster failed remote builds in B25141: Diff 34751!Dec 15 2023, 2:14 PM
Harbormaster completed remote builds in B25142: Diff 34752.Dec 15 2023, 2:23 PM
ginsu requested review of this revision.Dec 15 2023, 2:23 PM
ginsu added a child revision: D10390: [web] introduce unread badge component.Dec 18 2023, 1:03 PM
rohan accepted this revision.Dec 18 2023, 1:58 PM
This revision is now accepted and ready to land.Dec 18 2023, 1:58 PM
ginsu updated this revision to Diff 34937.Dec 21 2023, 3:06 PM

rebase before landing

Harbormaster completed remote builds in B25300: Diff 34937.Dec 21 2023, 4:25 PM
Closed by commit rCOMM963e77822c17: [web] introduce navigation sidebar (authored by ginsu). · Explain WhyDec 21 2023, 4:41 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM963e77822c17: [web] introduce navigation sidebar.

Revision Contents
Changeset List

PathSize
web/
navigation-sidebar/
15 lines
24 lines
2 lines

Diff 34945

View Options

web/navigation-sidebar/navigation-sidebar.css

Loading...
View Options

web/navigation-sidebar/navigation-sidebar.react.js

Loading...
View Options

web/theme.css

Loading...