Page MenuHomePhabricator
Differential D10360

[web] introduce community list
ClosedPublic
Actions

Authored by ginsu on Dec 15 2023, 12:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 10, 11:44 AM
Unknown Object (File)
Sat, Nov 23, 7:07 AM
Unknown Object (File)
Sat, Nov 23, 5:50 AM
Unknown Object (File)
Oct 30 2024, 11:54 PM
Unknown Object (File)
Oct 30 2024, 11:54 PM
Unknown Object (File)
Oct 30 2024, 11:54 PM
Unknown Object (File)
Oct 30 2024, 11:54 PM
Unknown Object (File)
Oct 30 2024, 11:54 PM
View All 56 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMM845969a02f4b: [web] introduce community list
Summary

This diff introduces the community list component that will be used in the navigation sidebar component (which will be introduced in a future diff)

For context on what this should look like here is a screenshot from the figma:

Screenshot 2023-12-15 at 3.56.48 PM.png (876×106 px, 45 KB)

Part of https://linear.app/comm/issue/ENG-5947/list-of-all-top-level-communites-communities

Depends on D10359

Test Plan

Please see the demo videos below

User with many communities:

user with not many communities:

Screenshot 2023-12-15 at 4.04.14 PM.png (1×3 px, 946 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 15 2023, 12:59 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 15 2023, 12:59 PM
ginsu edited the summary of this revision. (Show Details)Dec 15 2023, 1:02 PM
ginsu added reviewers: atul, rohan, kamil.
ginsu added a parent revision: D10358: [web] introduce useNavigationSidebarTooltip hook.
ginsu attached a referenced file: F954850: Screenshot 2023-12-15 at 3.56.48 PM.png. (Show Details)
ginsu edited the test plan for this revision. (Show Details)Dec 15 2023, 1:05 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 15 2023, 1:05 PM
Harbormaster failed remote builds in B25137: Diff 34747!
ginsu requested review of this revision.Dec 15 2023, 1:05 PM
ginsu attached a referenced file: F954899: Screenshot 2023-12-15 at 4.04.14 PM.png. (Show Details)
ginsu attached a referenced file: F954893: Screen Recording 2023-12-15 at 4.03.35 PM.mov. (Show Details)

will make sure ci passes before landing

ginsu edited the summary of this revision. (Show Details)Dec 15 2023, 1:10 PM
ginsu added a parent revision: D10359: [web] introduce community list item component.
ginsu removed a parent revision: D10358: [web] introduce useNavigationSidebarTooltip hook.
ginsu added a child revision: D10361: [web] introduce navigation sidebar home button.
rohan mentioned this in D10359: [web] introduce community list item component.Dec 15 2023, 4:33 PM
rohan accepted this revision.Dec 19 2023, 6:53 AM
rohan added inline comments.
web/navigation-sidebar/community-list.react.js
18–22 ↗(On Diff #34747)

Something like this might work

This revision is now accepted and ready to land.Dec 19 2023, 6:53 AM
ginsu updated this revision to Diff 34933.Dec 21 2023, 2:52 PM

address comments + rebase before landing

Harbormaster completed remote builds in B25296: Diff 34933.Dec 21 2023, 3:44 PM
Closed by commit rCOMM845969a02f4b: [web] introduce community list (authored by ginsu). · Explain WhyDec 21 2023, 4:41 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM845969a02f4b: [web] introduce community list.

Revision Contents
Changeset List

PathSize
web/
navigation-sidebar/
8 lines
29 lines

Diff 34941

View Options

web/navigation-sidebar/community-list.css

Loading...
View Options

web/navigation-sidebar/community-list.react.js

Loading...