Page MenuHomePhabricator
Differential D10435

[lib] introduce unreadCountSelectorForCommunity
ClosedPublic
Actions

Authored by ginsu on Dec 21 2023, 6:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 14, 6:53 PM
Unknown Object (File)
Mar 3 2025, 1:56 AM
Unknown Object (File)
Feb 23 2025, 10:19 PM
Unknown Object (File)
Jan 27 2025, 3:16 PM
Unknown Object (File)
Jan 22 2025, 11:19 PM
Unknown Object (File)
Jan 22 2025, 11:19 PM
Unknown Object (File)
Jan 22 2025, 11:19 PM
Unknown Object (File)
Jan 22 2025, 11:19 PM
View All 56 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
rohan
kamil
Commits
rCOMM8f76b89da5cd: [lib] introduce unreadCountSelectorForCommunity
Summary

This diff introduces a new selector that given a the id of a community it will return the unread count for that community. This diff should also address some feedback I got in D10393

Depends on D10391

Test Plan

Confirmed that I was getting the correct unread count for each community in my new nav sidebar

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 21 2023, 6:36 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 21 2023, 6:36 PM
ginsu edited the summary of this revision. (Show Details)Dec 21 2023, 6:37 PM
ginsu added reviewers: atul, rohan, kamil.
ginsu added a parent revision: D10391: [web] show total unreads in the navigation sidebar home button.
ginsu added a child revision: D10393: [web] show unreads for each community in the community list.
ginsu mentioned this in D10393: [web] show unreads for each community in the community list.
Harbormaster completed remote builds in B25305: Diff 34950.Dec 21 2023, 6:55 PM
ginsu requested review of this revision.Dec 21 2023, 6:55 PM
atul accepted this revision.Dec 26 2023, 5:13 PM
This revision is now accepted and ready to land.Dec 26 2023, 5:13 PM
ginsu updated this revision to Diff 35026.Dec 27 2023, 12:23 PM

rebasee before landing

This revision was landed with ongoing or failed builds.Dec 27 2023, 12:31 PM
Closed by commit rCOMM8f76b89da5cd: [lib] introduce unreadCountSelectorForCommunity (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM8f76b89da5cd: [lib] introduce unreadCountSelectorForCommunity.
Harbormaster completed remote builds in B25352: Diff 35026.Dec 27 2023, 12:46 PM

Revision Contents
Changeset List

PathSize
lib/
selectors/
22 lines

Diff 35028

View Options

lib/selectors/thread-selectors.js

Show First 20 Lines • Show All 81 Lines • ▼ Show 20 Lines
} from 'lib/types/message-types.js'; } from 'lib/types/message-types.js';
import type { RawImagesMessageInfo } from 'lib/types/messages/images.js'; import type { RawImagesMessageInfo } from 'lib/types/messages/images.js';
import type { RawMediaMessageInfo } from 'lib/types/messages/media.js'; import type { RawMediaMessageInfo } from 'lib/types/messages/media.js';
import type { RawTextMessageInfo } from 'lib/types/messages/text.js'; import type { RawTextMessageInfo } from 'lib/types/messages/text.js';
import type { ThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { ThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import type { Dispatch } from 'lib/types/redux-types.js'; import type { Dispatch } from 'lib/types/redux-types.js';
import { reportTypes } from 'lib/types/report-types.js'; import { reportTypes } from 'lib/types/report-types.js';
import { import {
thickThreadTypes,
threadTypeIsSidebar, threadTypeIsSidebar,
threadTypeIsThick, threadTypeIsThick,
} from 'lib/types/thread-types-enum.js'; } from 'lib/types/thread-types-enum.js';
import { import {
type ClientNewThinThreadRequest, type ClientNewThinThreadRequest,
type NewThreadResult, type NewThreadResult,
} from 'lib/types/thread-types.js'; } from 'lib/types/thread-types.js';
import { import {
▲ Show 20 Lines • Show All 1,180 Lines • ▼ Show 20 Lines async sendTextMessage(
inputThreadInfo: ThreadInfo, inputThreadInfo: ThreadInfo,
parentThreadInfo: ?ThreadInfo, parentThreadInfo: ?ThreadInfo,
) { ) {
this.props.sendCallbacks.forEach(callback => callback()); this.props.sendCallbacks.forEach(callback => callback());
// TODO: this should be update according to thread creation logic // TODO: this should be update according to thread creation logic
// (ENG-8567) // (ENG-8567)
if (threadTypeIsThick(inputThreadInfo.type)) { if (threadTypeIsThick(inputThreadInfo.type)) {
const recipientIDs = inputThreadInfo.members.map(member => member.id);
void this.props.processAndSendDMOperation({ void this.props.processAndSendDMOperation({
type: dmOperationSpecificationTypes.OUTBOUND, type: dmOperationSpecificationTypes.OUTBOUND,
op: { op: {
type: 'send_text_message', type: 'send_text_message',
threadID: inputThreadInfo.id, threadID: inputThreadInfo.id,
creatorID: messageInfo.creatorID, creatorID: messageInfo.creatorID,
time: Date.now(), time: Date.now(),
messageID: uuid.v4(), messageID: uuid.v4(),
text: messageInfo.text, text: messageInfo.text,
}, },
recipients: { recipients: {
type: 'some_users', type: 'all_thread_members',
userIDs: recipientIDs, threadID:
inputThreadInfo.type === thickThreadTypes.THICK_SIDEBAR &&
inputThreadInfo.parentThreadID
? inputThreadInfo.parentThreadID
: inputThreadInfo.id,
}, },
}); });
return; return;
} }
const { localID } = messageInfo; const { localID } = messageInfo;
invariant( invariant(
localID !== null && localID !== undefined, localID !== null && localID !== undefined,
▲ Show 20 Lines • Show All 455 Lines • Show Last 20 Lines