Page MenuHomePhabricator

[lib] Memoize userinfos in usePotentialMemberItems
ClosedPublic

Authored by rohan on Dec 19 2023, 8:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Apr 14, 2:56 PM
Unknown Object (File)
Sun, Apr 14, 2:56 PM
Unknown Object (File)
Sun, Apr 14, 2:56 PM
Unknown Object (File)
Sun, Apr 14, 2:56 PM
Unknown Object (File)
Feb 23 2024, 7:32 PM
Unknown Object (File)
Feb 23 2024, 7:31 PM
Unknown Object (File)
Feb 23 2024, 5:48 PM
Unknown Object (File)
Feb 23 2024, 5:08 PM
Subscribers

Details

Summary

This addresses the urgent issue outlined in ENG-6139. I should've memoized the userInfos object.

Test Plan

Since usePotentialMemberItems is used in both chat-thread-composer.react.js and add-members-modal.react.js (both also mentioned in the original bug report), I made sure that those both no longer completely freeze/crash.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable