[lib] Memoize userinfos in usePotentialMemberItems
ClosedPublic
Actions

Authored by rohan on Dec 19 2023, 8:47 PM.

Details

Reviewers

ashoat
michal

Commits

rCOMMf6eaff7c3230: [lib] Memoize userinfos in usePotentialMemberItems

Summary

This addresses the urgent issue outlined in ENG-6139. I should've memoized the userInfos object.

Test Plan

Since usePotentialMemberItems is used in both chat-thread-composer.react.js and add-members-modal.react.js (both also mentioned in the original bug report), I made sure that those both no longer completely freeze/crash.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Dec 19 2023, 8:47 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 19 2023, 8:47 PM

Harbormaster completed remote builds in B25239: Diff 34868.Dec 19 2023, 9:05 PM

rohan requested review of this revision.Dec 19 2023, 9:05 PM

ashoat accepted this revision.Dec 20 2023, 6:27 AM

This revision is now accepted and ready to land.Dec 20 2023, 6:27 AM

Closed by commit rCOMMf6eaff7c3230: [lib] Memoize userinfos in usePotentialMemberItems (authored by rohan). · Explain WhyDec 20 2023, 7:02 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMMf6eaff7c3230: [lib] Memoize userinfos in usePotentialMemberItems.

ashoat mentioned this in D13874: [lib] Avoid creating new array on every invocation of useThreadHasPermission.Thu, Nov 7, 5:13 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

search-utils.js

3 lines

Diff 34876

View Options

lib/shared/search-utils.js

[lib] Memoize userinfos in usePotentialMemberItemsClosedPublicActions