[lib] Memoize userinfos in usePotentialMemberItems
ClosedPublic
Actions

Authored by rohan on Dec 19 2023, 8:47 PM.

Details

Reviewers

ashoat
michal

Commits

rCOMMf6eaff7c3230: [lib] Memoize userinfos in usePotentialMemberItems

Summary

This addresses the urgent issue outlined in ENG-6139. I should've memoized the userInfos object.

Test Plan

Since usePotentialMemberItems is used in both chat-thread-composer.react.js and add-members-modal.react.js (both also mentioned in the original bug report), I made sure that those both no longer completely freeze/crash.

Diff Detail

Repository

rCOMM Comm

Branch

fix

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

rohan created this revision.Dec 19 2023, 8:47 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 19 2023, 8:47 PM

Harbormaster completed remote builds in B25239: Diff 34868.Dec 19 2023, 9:05 PM

rohan requested review of this revision.Dec 19 2023, 9:05 PM

ashoat accepted this revision.Dec 20 2023, 6:27 AM

This revision is now accepted and ready to land.Dec 20 2023, 6:27 AM

Closed by commit rCOMMf6eaff7c3230: [lib] Memoize userinfos in usePotentialMemberItems (authored by rohan). · Explain WhyDec 20 2023, 7:02 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMMf6eaff7c3230: [lib] Memoize userinfos in usePotentialMemberItems.

ashoat mentioned this in D13874: [lib] Avoid creating new array on every invocation of useThreadHasPermission.Nov 7 2024, 5:13 AM

ashoat mentioned this in D14204: [native] fix avatars in directory.Jan 30 2025, 10:38 AM

Revision Contents
Changeset List

Path

Size

lib/

shared/

search-utils.js

3 lines

Diff 34868

View Options

lib/shared/search-utils.js

Show First 20 Lines • Show All 739 Lines • ▼ Show 20 Lines	async () => {
SQL`		SQL`
ALTER TABLE updates		ALTER TABLE updates
MODIFY \`key\` varchar(255) CHARSET latin1 COLLATE latin1_bin		MODIFY \`key\` varchar(255) CHARSET latin1 COLLATE latin1_bin
`,		`,
);		);
},		},
],		],
[59, () => dbQuery(SQL`DROP TABLE one_time_keys`)],		[59, () => dbQuery(SQL`DROP TABLE one_time_keys`)],
		[
		60,
		async () => {
		await dbQuery(
		SQL`
		DELETE
		FROM messages
		WHERE type = 22
		AND JSON_EXTRACT(content, '$.operation') = 'farcaster_mutual'
		`,
		);
		},
		],
]);		]);
const newDatabaseVersion: number = Math.max(...migrations.keys());		const newDatabaseVersion: number = Math.max(...migrations.keys());

async function writeJSONToFile(data: any, filePath: string): Promise<void> {		async function writeJSONToFile(data: any, filePath: string): Promise<void> {
console.warn(`updating ${filePath} to ${JSON.stringify(data)}`);		console.warn(`updating ${filePath} to ${JSON.stringify(data)}`);
const fileHandle = await fs.promises.open(filePath, 'w');		const fileHandle = await fs.promises.open(filePath, 'w');
await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8');		await fileHandle.writeFile(JSON.stringify(data, null, ' '), 'utf8');
await fileHandle.close();		await fileHandle.close();
▲ Show 20 Lines • Show All 130 Lines • Show Last 20 Lines

[lib] Memoize userinfos in usePotentialMemberItemsClosedPublicActions