Paths

Table of Contentst

Differential D10494

[lib/web/native] Show viewer in @-mentioning tooltip
ClosedPublic
Actions

Authored by rohan on Dec 29 2023, 9:40 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Apr 9, 12:35 AM

	Unknown Object (File)
	Tue, Apr 9, 12:35 AM

	Unknown Object (File)
	Tue, Apr 9, 12:32 AM

	Unknown Object (File)
	Mon, Apr 8, 6:50 PM

	Unknown Object (File)
	Mar 12 2024, 10:19 AM

	Unknown Object (File)
	Mar 7 2024, 2:02 PM

	Unknown Object (File)
	Mar 7 2024, 12:53 PM

	Unknown Object (File)
	Mar 7 2024, 12:51 PM

View All 19 Files

Subscribers

Details

Reviewers

atul
ginsu
inka
ashoat

Commits

rCOMMe1798c21a902: [lib/web/native] Show viewer in @-mentioning tooltip

Summary

This enables users to see themselves in the @-mention tooltip so they can mention themselves. We won't have to make any changes to the user-profile on web/native since we already only just show the 'Message' button if otherUserInfo is undefined.

This does not need to be landed if we decide we don't want to enable this feature

This is part of ENG-6297

Test Plan

Please see the videos below

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rohan created this revision.Dec 29 2023, 9:40 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 29 2023, 9:40 AM

rohan edited the test plan for this revision. (Show Details)Dec 29 2023, 9:42 AM

Harbormaster completed remote builds in B25405: Diff 35103.Dec 29 2023, 10:00 AM

rohan requested review of this revision.Dec 29 2023, 10:00 AM

rohan edited the summary of this revision. (Show Details)Dec 29 2023, 10:01 AM

rohan added a child revision: D10495: [keyserver] Prevent self-mentions from pushing notifs to user.Dec 29 2023, 10:02 AM

ashoat accepted this revision.Dec 29 2023, 10:25 AM

This revision is now accepted and ready to land.Dec 29 2023, 10:25 AM

Closed by commit rCOMMe1798c21a902: [lib/web/native] Show viewer in @-mentioning tooltip (authored by rohan). · Explain WhyDec 29 2023, 10:33 AM

This revision was automatically updated to reflect the committed changes.

rohan added a commit: rCOMMe1798c21a902: [lib/web/native] Show viewer in @-mentioning tooltip.

Revision Contents
Changeset List

Path

Size

lib/

shared/

mention-utils.js

6 lines

native/

chat/

chat-input-bar.react.js

1 line

web/

chat/

chat-input-bar.react.js

1 line

Diff 35105

lib/shared/mention-utils.js

Loading...

native/chat/chat-input-bar.react.js

Loading...

web/chat/chat-input-bar.react.js

Loading...