Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F32221595
D8828.1765198713.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Flag For Later
Award Token
Size
3 KB
Referenced Files
None
Subscribers
None
D8828.1765198713.diff
View Options
diff --git a/web/utils/tooltip-action-utils.js b/web/utils/tooltip-action-utils.js
--- a/web/utils/tooltip-action-utils.js
+++ b/web/utils/tooltip-action-utils.js
@@ -21,16 +21,13 @@
import {
type MessageTooltipAction,
- findTooltipPosition,
- getTooltipStyle,
+ getTooltipPositionStyle,
calculateTooltipSize,
- type TooltipSize,
type TooltipPosition,
} from './tooltip-utils.js';
import { getComposedMessageID } from '../chat/chat-constants.js';
import { useEditModalContext } from '../chat/edit-message-provider.js';
import MessageTooltip from '../chat/message-tooltip.react.js';
-import type { PositionInfo } from '../chat/position-types.js';
import { useTooltipContext } from '../chat/tooltip-provider.js';
import CommIcon from '../CommIcon.react.js';
import { InputStateContext } from '../input/input-state.js';
@@ -305,43 +302,6 @@
onMouseLeave: ?() => mixed,
};
-type GetTooltipPositionStyleParams = {
- +tooltipSourcePosition: ?PositionInfo,
- +tooltipSize: TooltipSize,
- +availablePositions: $ReadOnlyArray<TooltipPosition>,
- +preventDisplayingBelowSource?: boolean,
-};
-
-function getTooltipPositionStyle(params: GetTooltipPositionStyleParams) {
- const {
- tooltipSourcePosition,
- tooltipSize,
- availablePositions,
- preventDisplayingBelowSource,
- } = params;
- if (!tooltipSourcePosition) {
- return undefined;
- }
- const tooltipPosition = findTooltipPosition({
- sourcePositionInfo: tooltipSourcePosition,
- tooltipSize,
- availablePositions,
- defaultPosition: availablePositions[0],
- preventDisplayingBelowSource,
- });
- if (!tooltipPosition) {
- return undefined;
- }
-
- const tooltipPositionStyle = getTooltipStyle({
- tooltipPosition,
- sourcePositionInfo: tooltipSourcePosition,
- tooltipSize,
- });
-
- return tooltipPositionStyle;
-}
-
function useMessageTooltip({
availablePositions,
item,
diff --git a/web/utils/tooltip-utils.js b/web/utils/tooltip-utils.js
--- a/web/utils/tooltip-utils.js
+++ b/web/utils/tooltip-utils.js
@@ -283,6 +283,45 @@
invariant(false, `Unexpected tooltip position value: ${tooltipPosition}`);
}
+type GetTooltipPositionStyleParams = {
+ +tooltipSourcePosition: ?PositionInfo,
+ +tooltipSize: TooltipSize,
+ +availablePositions: $ReadOnlyArray<TooltipPosition>,
+ +preventDisplayingBelowSource?: boolean,
+};
+
+function getTooltipPositionStyle(
+ params: GetTooltipPositionStyleParams,
+): ?TooltipPositionStyle {
+ const {
+ tooltipSourcePosition,
+ tooltipSize,
+ availablePositions,
+ preventDisplayingBelowSource,
+ } = params;
+ if (!tooltipSourcePosition) {
+ return undefined;
+ }
+ const tooltipPosition = findTooltipPosition({
+ sourcePositionInfo: tooltipSourcePosition,
+ tooltipSize,
+ availablePositions,
+ defaultPosition: availablePositions[0],
+ preventDisplayingBelowSource,
+ });
+ if (!tooltipPosition) {
+ return undefined;
+ }
+
+ const tooltipPositionStyle = getTooltipStyle({
+ tooltipPosition,
+ sourcePositionInfo: tooltipSourcePosition,
+ tooltipSize,
+ });
+
+ return tooltipPositionStyle;
+}
+
type CalculateTooltipSizeArgs = {
+tooltipLabels: $ReadOnlyArray<string>,
+timestamp: string,
@@ -317,4 +356,4 @@
};
}
-export { findTooltipPosition, calculateTooltipSize, getTooltipStyle };
+export { findTooltipPosition, getTooltipPositionStyle, calculateTooltipSize };
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Dec 8, 12:58 PM (4 h, 14 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
5846726
Default Alt Text
D8828.1765198713.diff (3 KB)
Attached To
Mode
D8828: [web] move getTooltipPositionStyle into tooltip-utils
Attached
Detach File
Event Timeline
Log In to Comment