Page MenuHomePhabricator
Differential D8828

[web] move getTooltipPositionStyle into tooltip-utils
ClosedPublic
Actions

Authored by ginsu on Aug 15 2023, 11:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 4:46 PM
Unknown Object (File)
Mon, Mar 17, 4:46 PM
Unknown Object (File)
Mon, Mar 17, 4:46 PM
Unknown Object (File)
Mon, Mar 17, 4:45 PM
Unknown Object (File)
Mon, Mar 17, 4:23 PM
Unknown Object (File)
Mon, Mar 10, 3:31 PM
Unknown Object (File)
Mon, Mar 3, 4:09 PM
Unknown Object (File)
Feb 23 2025, 8:21 PM
View All 85 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM6c13fc182944: [web] move getTooltipPositionStyle into tooltip-utils
Summary

simple move diff. Thought it made more sense for getTooltipPositionStyle to be living in tooltip-utils instaed of tooltip-action-utils

Depends on D8827

Test Plan

flow and confirmed that the message tooltip looks and behaves as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Aug 15 2023, 11:51 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 15 2023, 11:51 PM
ginsu added inline comments.Aug 15 2023, 11:53 PM
web/utils/tooltip-utils.js
295 ↗(On Diff #29935)

This is the only change I made during this move diff

ginsu edited the summary of this revision. (Show Details)Aug 15 2023, 11:54 PM
ginsu added a parent revision: D8827: [web] convert createTooltip to getTooltipPositionStyle.
Harbormaster completed remote builds in B21781: Diff 29935.Aug 16 2023, 12:09 AM
ginsu requested review of this revision.Aug 16 2023, 12:09 AM
ginsu added a child revision: D8829: [web] introduce useTooltip hook.Aug 16 2023, 12:13 AM
ashoat added a comment.Aug 16 2023, 12:18 PM

There are no reviewers specified – is this one a draft too?

ginsu added reviewers: atul, kamil.Aug 16 2023, 1:38 PM

There are no reviewers specified – is this one a draft too?

Oops my bad, thanks for that catch!

kamil accepted this revision.Aug 17 2023, 1:02 AM
This revision is now accepted and ready to land.Aug 17 2023, 1:02 AM
ginsu updated this revision to Diff 30385.Aug 27 2023, 8:56 PM

rebase before landing

Harbormaster completed remote builds in B22139: Diff 30385.Aug 27 2023, 9:13 PM
Closed by commit rCOMM6c13fc182944: [web] move getTooltipPositionStyle into tooltip-utils (authored by ginsu). · Explain WhyAug 27 2023, 10:04 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM6c13fc182944: [web] move getTooltipPositionStyle into tooltip-utils.

Revision Contents
Changeset List

PathSize
web/
utils/
42 lines
41 lines

Diff 30400

View Options

web/utils/tooltip-action-utils.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import Animated from 'react-native-reanimated'; import Animated from 'react-native-reanimated';
import { localIDPrefix } from 'lib/shared/message-utils.js'; import { useNextLocalID } from 'lib/shared/message-utils.js';
import { import {
useViewerAlreadySelectedMessageReactions, useViewerAlreadySelectedMessageReactions,
useCanCreateReactionFromMessage, useCanCreateReactionFromMessage,
} from 'lib/shared/reaction-utils.js'; } from 'lib/shared/reaction-utils.js';
import { TooltipInlineEngagement } from './inline-engagement.react.js'; import { TooltipInlineEngagement } from './inline-engagement.react.js';
import { InnerRobotextMessage } from './inner-robotext-message.react.js'; import { InnerRobotextMessage } from './inner-robotext-message.react.js';
import { useSendReaction } from './reaction-message-utils.js'; import { useSendReaction } from './reaction-message-utils.js';
▲ Show 20 Lines • Show All 66 Lines • ▼ Show 20 Lines return (
progress={progress} progress={progress}
windowWidth={windowWidth} windowWidth={windowWidth}
initialCoordinates={initialCoordinates} initialCoordinates={initialCoordinates}
/> />
); );
}, [initialCoordinates, isOpeningSidebar, item, progress, windowWidth]); }, [initialCoordinates, isOpeningSidebar, item, progress, windowWidth]);
const { messageInfo, threadInfo, reactions } = item; const { messageInfo, threadInfo, reactions } = item;
const nextLocalID = useSelector(state => state.nextLocalID); const localID = useNextLocalID();
const localID = `${localIDPrefix}${nextLocalID}`;
const canCreateReactionFromMessage = useCanCreateReactionFromMessage( const canCreateReactionFromMessage = useCanCreateReactionFromMessage(
threadInfo, threadInfo,
messageInfo, messageInfo,
); );
const sendReaction = useSendReaction( const sendReaction = useSendReaction(
messageInfo.id, messageInfo.id,
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines
View Options

web/utils/tooltip-utils.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import Animated from 'react-native-reanimated'; import Animated from 'react-native-reanimated';
import { localIDPrefix } from 'lib/shared/message-utils.js'; import { useNextLocalID } from 'lib/shared/message-utils.js';
import { import {
useViewerAlreadySelectedMessageReactions, useViewerAlreadySelectedMessageReactions,
useCanCreateReactionFromMessage, useCanCreateReactionFromMessage,
} from 'lib/shared/reaction-utils.js'; } from 'lib/shared/reaction-utils.js';
import { TooltipInlineEngagement } from './inline-engagement.react.js'; import { TooltipInlineEngagement } from './inline-engagement.react.js';
import { InnerRobotextMessage } from './inner-robotext-message.react.js'; import { InnerRobotextMessage } from './inner-robotext-message.react.js';
import { useSendReaction } from './reaction-message-utils.js'; import { useSendReaction } from './reaction-message-utils.js';
▲ Show 20 Lines • Show All 66 Lines • ▼ Show 20 Lines return (
progress={progress} progress={progress}
windowWidth={windowWidth} windowWidth={windowWidth}
initialCoordinates={initialCoordinates} initialCoordinates={initialCoordinates}
/> />
); );
}, [initialCoordinates, isOpeningSidebar, item, progress, windowWidth]); }, [initialCoordinates, isOpeningSidebar, item, progress, windowWidth]);
const { messageInfo, threadInfo, reactions } = item; const { messageInfo, threadInfo, reactions } = item;
const nextLocalID = useSelector(state => state.nextLocalID); const localID = useNextLocalID();
const localID = `${localIDPrefix}${nextLocalID}`;
const canCreateReactionFromMessage = useCanCreateReactionFromMessage( const canCreateReactionFromMessage = useCanCreateReactionFromMessage(
threadInfo, threadInfo,
messageInfo, messageInfo,
); );
const sendReaction = useSendReaction( const sendReaction = useSendReaction(
messageInfo.id, messageInfo.id,
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines