Page MenuHomePhabricator
Differential D8684

[web] clean up edited label
ClosedPublic
Actions

Authored by ginsu on Jul 31 2023, 11:22 AM.
Tags
None
Referenced Files
F5055991: D8684.id29298.diff
Tue, Mar 25, 7:16 PM
Unknown Object (File)
Thu, Mar 20, 3:15 AM
Unknown Object (File)
Thu, Mar 20, 3:15 AM
Unknown Object (File)
Mon, Mar 17, 6:16 PM
Unknown Object (File)
Mon, Mar 17, 6:16 PM
Unknown Object (File)
Mon, Mar 17, 6:16 PM
Unknown Object (File)
Mon, Mar 17, 6:15 PM
Unknown Object (File)
Mon, Mar 17, 6:07 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM1e7c476d9438: [web] clean up edited label
Summary

Small cleanup diff which simplifies the logic around the editedLabel and always makes the structure of the web InlineEngagement component symmetrical to the native InlineEngagement component

Depends on D8678

Test Plan

flow and confirmed that there were no regresions with the web InlineEngagement

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Jul 31 2023, 11:22 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJul 31 2023, 11:22 AM
ginsu edited the summary of this revision. (Show Details)Jul 31 2023, 11:25 AM
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8678: [web] split the inline engagement pill into two.
ginsu published this revision for review.Jul 31 2023, 11:50 AM
Harbormaster completed remote builds in B21386: Diff 29298.Jul 31 2023, 12:10 PM
atul accepted this revision.Aug 1 2023, 2:16 PM
atul added inline comments.
web/chat/inline-engagement.css
54 ↗(On Diff #29298)

Thanks for annotating this! I think this sort of note will help prevent subtle layout/styling regressions in the future

web/chat/inline-engagement.react.js
28 ↗(On Diff #29298)

I'd maybe just inline this within the call to classNames, totally arbitrary and personal preference so up to you

This revision is now accepted and ready to land.Aug 1 2023, 2:16 PM
ginsu added a child revision: D8707: [web] add space between inline engagement container and edges of chat window.Aug 2 2023, 11:47 AM
ginsu updated this revision to Diff 30361.Aug 27 2023, 7:47 PM

rebase before landing

Harbormaster completed remote builds in B22127: Diff 30361.Aug 27 2023, 8:04 PM
Closed by commit rCOMM1e7c476d9438: [web] clean up edited label (authored by ginsu). · Explain WhyAug 27 2023, 8:34 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM1e7c476d9438: [web] clean up edited label.

Revision Contents
Changeset List

PathSize
web/
chat/
7 lines
50 lines

Diff 30373

View Options

web/chat/inline-engagement.css

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import Animated from 'react-native-reanimated'; import Animated from 'react-native-reanimated';
import { localIDPrefix } from 'lib/shared/message-utils.js'; import { useNextLocalID } from 'lib/shared/message-utils.js';
import { import {
useViewerAlreadySelectedMessageReactions, useViewerAlreadySelectedMessageReactions,
useCanCreateReactionFromMessage, useCanCreateReactionFromMessage,
} from 'lib/shared/reaction-utils.js'; } from 'lib/shared/reaction-utils.js';
import { TooltipInlineEngagement } from './inline-engagement.react.js'; import { TooltipInlineEngagement } from './inline-engagement.react.js';
import { InnerRobotextMessage } from './inner-robotext-message.react.js'; import { InnerRobotextMessage } from './inner-robotext-message.react.js';
import { useSendReaction } from './reaction-message-utils.js'; import { useSendReaction } from './reaction-message-utils.js';
▲ Show 20 Lines • Show All 66 Lines • ▼ Show 20 Lines return (
progress={progress} progress={progress}
windowWidth={windowWidth} windowWidth={windowWidth}
initialCoordinates={initialCoordinates} initialCoordinates={initialCoordinates}
/> />
); );
}, [initialCoordinates, isOpeningSidebar, item, progress, windowWidth]); }, [initialCoordinates, isOpeningSidebar, item, progress, windowWidth]);
const { messageInfo, threadInfo, reactions } = item; const { messageInfo, threadInfo, reactions } = item;
const nextLocalID = useSelector(state => state.nextLocalID); const localID = useNextLocalID();
const localID = `${localIDPrefix}${nextLocalID}`;
const canCreateReactionFromMessage = useCanCreateReactionFromMessage( const canCreateReactionFromMessage = useCanCreateReactionFromMessage(
threadInfo, threadInfo,
messageInfo, messageInfo,
); );
const sendReaction = useSendReaction( const sendReaction = useSendReaction(
messageInfo.id, messageInfo.id,
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines
View Options

web/chat/inline-engagement.react.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import Animated from 'react-native-reanimated'; import Animated from 'react-native-reanimated';
import { localIDPrefix } from 'lib/shared/message-utils.js'; import { useNextLocalID } from 'lib/shared/message-utils.js';
import { import {
useViewerAlreadySelectedMessageReactions, useViewerAlreadySelectedMessageReactions,
useCanCreateReactionFromMessage, useCanCreateReactionFromMessage,
} from 'lib/shared/reaction-utils.js'; } from 'lib/shared/reaction-utils.js';
import { TooltipInlineEngagement } from './inline-engagement.react.js'; import { TooltipInlineEngagement } from './inline-engagement.react.js';
import { InnerRobotextMessage } from './inner-robotext-message.react.js'; import { InnerRobotextMessage } from './inner-robotext-message.react.js';
import { useSendReaction } from './reaction-message-utils.js'; import { useSendReaction } from './reaction-message-utils.js';
▲ Show 20 Lines • Show All 66 Lines • ▼ Show 20 Lines return (
progress={progress} progress={progress}
windowWidth={windowWidth} windowWidth={windowWidth}
initialCoordinates={initialCoordinates} initialCoordinates={initialCoordinates}
/> />
); );
}, [initialCoordinates, isOpeningSidebar, item, progress, windowWidth]); }, [initialCoordinates, isOpeningSidebar, item, progress, windowWidth]);
const { messageInfo, threadInfo, reactions } = item; const { messageInfo, threadInfo, reactions } = item;
const nextLocalID = useSelector(state => state.nextLocalID); const localID = useNextLocalID();
const localID = `${localIDPrefix}${nextLocalID}`;
const canCreateReactionFromMessage = useCanCreateReactionFromMessage( const canCreateReactionFromMessage = useCanCreateReactionFromMessage(
threadInfo, threadInfo,
messageInfo, messageInfo,
); );
const sendReaction = useSendReaction( const sendReaction = useSendReaction(
messageInfo.id, messageInfo.id,
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines