Page MenuHomePhabricator

[web] convert createTooltip to getTooltipPositionStyle
ClosedPublic

Authored by ginsu on Aug 15 2023, 11:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 1:23 PM
Unknown Object (File)
Mon, Oct 28, 5:39 AM
Unknown Object (File)
Mon, Oct 28, 5:39 AM
Unknown Object (File)
Mon, Oct 28, 5:39 AM
Unknown Object (File)
Mon, Oct 28, 5:39 AM
Unknown Object (File)
Mon, Oct 28, 5:36 AM
Unknown Object (File)
Sep 30 2024, 3:27 AM
Unknown Object (File)
Sep 28 2024, 8:22 AM
Subscribers

Details

Summary

In an effort to make the tooltip code more component agnostic, I refactored this function to only get and return the tooltip position style since this logic can be reused for every single different type of tooltip we introduce in the future (which we are about to do shortly), and factored out any message tooltip specific code and put it back into the useMessageTooltip hook

Depends on D8826

Test Plan

flow and confirmed that the message tooltip on web still behaves and works as expected

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu added reviewers: atul, kamil.
ginsu edited the summary of this revision. (Show Details)
ginsu edited the summary of this revision. (Show Details)

not really familiar with tooltip code

Looks good, would prefer if someone more familiar with the tooltip could confirm though since my changes were mainly just fixing a cyclic dependency issue

This revision is now accepted and ready to land.Aug 17 2023, 10:41 AM

would prefer if someone more familiar with the tooltip could confirm

Making @atul blocking

This revision now requires review to proceed.Aug 17 2023, 1:30 PM
This revision is now accepted and ready to land.Aug 27 2023, 11:00 AM