Page MenuHomePhabricator
Differential D8831

[web] update calculateMaxTextWidth to consider different font sizes
ClosedPublic
Actions

Authored by ginsu on Aug 16 2023, 12:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, May 4, 2:45 PM
Unknown Object (File)
Mar 8 2024, 3:07 PM
Unknown Object (File)
Mar 7 2024, 5:49 AM
Unknown Object (File)
Mar 5 2024, 1:25 AM
Unknown Object (File)
Feb 21 2024, 12:21 PM
Unknown Object (File)
Feb 21 2024, 8:54 AM
Unknown Object (File)
Feb 21 2024, 7:22 AM
Unknown Object (File)
Feb 20 2024, 12:21 PM
View All 26 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMMe88bb4c1762d: [web] update calculateMaxTextWidth to consider different font sizes
Summary

Our reaction tooltip has texts with two different font sizes (see image below for context) to accommodate for this I updated calculateMaxTextWidth to consider different font sizes so that we can use this function when we introduce the reaction tooltip

Screenshot 2023-08-16 at 3.25.58 AM.png (306×316 px, 24 KB)

Depends on D8829

Test Plan

flow and confirmed that the result of calculateMaxTextWidth was the same before and after the changes

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Aug 16 2023, 12:23 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 16 2023, 12:23 AM
ginsu edited the summary of this revision. (Show Details)Aug 16 2023, 12:26 AM
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8829: [web] introduce useTooltip hook.
ginsu attached a referenced file: F690985: Screenshot 2023-08-16 at 3.25.58 AM.png. (Show Details)
Harbormaster completed remote builds in B21785: Diff 29939.Aug 16 2023, 12:40 AM
ginsu requested review of this revision.Aug 16 2023, 12:40 AM
ginsu added a child revision: D8823: [web] introduce ReactionTooltip component.Aug 17 2023, 10:29 AM
kamil accepted this revision.Aug 24 2023, 1:39 PM
This revision is now accepted and ready to land.Aug 24 2023, 1:39 PM
ginsu updated this revision to Diff 30387.Aug 27 2023, 8:57 PM

rebase before landing

Harbormaster completed remote builds in B22141: Diff 30387.Aug 27 2023, 9:14 PM
Closed by commit rCOMMe88bb4c1762d: [web] update calculateMaxTextWidth to consider different font sizes (authored by ginsu). · Explain WhyAug 27 2023, 10:04 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMe88bb4c1762d: [web] update calculateMaxTextWidth to consider different font sizes.

Revision Contents
Changeset List

PathSize
web/
utils/
6 lines
6 lines

Diff 30402

View Options

web/utils/text-utils.js

Loading...
View Options

web/utils/tooltip-utils.js

Loading...