Page MenuHomePhabricator

[web] update calculateMaxTextWidth to consider different font sizes
ClosedPublic

Authored by ginsu on Aug 16 2023, 12:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 3:29 PM
Unknown Object (File)
Sat, Nov 23, 1:59 PM
Unknown Object (File)
Tue, Nov 12, 11:56 PM
Unknown Object (File)
Oct 28 2024, 6:41 AM
Unknown Object (File)
Oct 28 2024, 6:41 AM
Unknown Object (File)
Oct 28 2024, 6:41 AM
Unknown Object (File)
Oct 28 2024, 6:41 AM
Unknown Object (File)
Oct 28 2024, 6:39 AM
Subscribers

Details

Summary

Our reaction tooltip has texts with two different font sizes (see image below for context) to accommodate for this I updated calculateMaxTextWidth to consider different font sizes so that we can use this function when we introduce the reaction tooltip

Screenshot 2023-08-16 at 3.25.58 AM.png (306×316 px, 24 KB)

Depends on D8829

Test Plan

flow and confirmed that the result of calculateMaxTextWidth was the same before and after the changes

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 24 2023, 1:39 PM