Page MenuHomePhabricator
Differential D8858

[web] rename calculateToolTipSize to calculateMessageTooltipSize
ClosedPublic
Actions

Authored by ginsu on Aug 17 2023, 5:59 PM.
Tags
None
Referenced Files
F5057634: D8858.id30050.diff
Wed, Mar 26, 1:05 AM
Unknown Object (File)
Mon, Mar 17, 4:46 PM
Unknown Object (File)
Mon, Mar 17, 4:46 PM
Unknown Object (File)
Mon, Mar 17, 4:46 PM
Unknown Object (File)
Mon, Mar 17, 4:45 PM
Unknown Object (File)
Mon, Mar 17, 4:23 PM
Unknown Object (File)
Mon, Mar 10, 10:04 PM
Unknown Object (File)
Wed, Mar 5, 11:35 AM
View All 98 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMM2be07376adff: [web] rename calculateToolTipSize to calculateMessageTooltipSize
Summary

this function calculates the size of the message tooltip so calculateMessageTooltipSize is a more accurate name

Depends on D8823

Test Plan

flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Aug 17 2023, 5:59 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 17 2023, 5:59 PM
ginsu edited the summary of this revision. (Show Details)Aug 17 2023, 6:00 PM
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8823: [web] introduce ReactionTooltip component.
Harbormaster completed remote builds in B21872: Diff 30050.Aug 17 2023, 6:20 PM
ginsu requested review of this revision.Aug 17 2023, 6:20 PM
ginsu added a child revision: D8857: [web] introduce calculateReactionTooltipSize function.Aug 17 2023, 6:28 PM
kamil accepted this revision.Aug 24 2023, 1:51 PM
This revision is now accepted and ready to land.Aug 24 2023, 1:51 PM
ginsu updated this revision to Diff 30390.Aug 27 2023, 9:03 PM

rebase before landing

Harbormaster completed remote builds in B22144: Diff 30390.Aug 27 2023, 9:20 PM
Closed by commit rCOMM2be07376adff: [web] rename calculateToolTipSize to calculateMessageTooltipSize (authored by ginsu). · Explain WhyAug 27 2023, 10:04 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM2be07376adff: [web] rename calculateToolTipSize to calculateMessageTooltipSize.

Revision Contents
Changeset List

PathSize
web/
utils/
4 lines
15 lines

Diff 30404

View Options

web/utils/tooltip-action-utils.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import Animated from 'react-native-reanimated'; import Animated from 'react-native-reanimated';
import { localIDPrefix } from 'lib/shared/message-utils.js'; import { useNextLocalID } from 'lib/shared/message-utils.js';
import { import {
useViewerAlreadySelectedMessageReactions, useViewerAlreadySelectedMessageReactions,
useCanCreateReactionFromMessage, useCanCreateReactionFromMessage,
} from 'lib/shared/reaction-utils.js'; } from 'lib/shared/reaction-utils.js';
import { TooltipInlineEngagement } from './inline-engagement.react.js'; import { TooltipInlineEngagement } from './inline-engagement.react.js';
import { InnerRobotextMessage } from './inner-robotext-message.react.js'; import { InnerRobotextMessage } from './inner-robotext-message.react.js';
import { useSendReaction } from './reaction-message-utils.js'; import { useSendReaction } from './reaction-message-utils.js';
▲ Show 20 Lines • Show All 66 Lines • ▼ Show 20 Lines return (
progress={progress} progress={progress}
windowWidth={windowWidth} windowWidth={windowWidth}
initialCoordinates={initialCoordinates} initialCoordinates={initialCoordinates}
/> />
); );
}, [initialCoordinates, isOpeningSidebar, item, progress, windowWidth]); }, [initialCoordinates, isOpeningSidebar, item, progress, windowWidth]);
const { messageInfo, threadInfo, reactions } = item; const { messageInfo, threadInfo, reactions } = item;
const nextLocalID = useSelector(state => state.nextLocalID); const localID = useNextLocalID();
const localID = `${localIDPrefix}${nextLocalID}`;
const canCreateReactionFromMessage = useCanCreateReactionFromMessage( const canCreateReactionFromMessage = useCanCreateReactionFromMessage(
threadInfo, threadInfo,
messageInfo, messageInfo,
); );
const sendReaction = useSendReaction( const sendReaction = useSendReaction(
messageInfo.id, messageInfo.id,
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines
View Options

web/utils/tooltip-utils.js

// @flow // @flow
import * as React from 'react'; import * as React from 'react';
import Animated from 'react-native-reanimated'; import Animated from 'react-native-reanimated';
import { localIDPrefix } from 'lib/shared/message-utils.js'; import { useNextLocalID } from 'lib/shared/message-utils.js';
import { import {
useViewerAlreadySelectedMessageReactions, useViewerAlreadySelectedMessageReactions,
useCanCreateReactionFromMessage, useCanCreateReactionFromMessage,
} from 'lib/shared/reaction-utils.js'; } from 'lib/shared/reaction-utils.js';
import { TooltipInlineEngagement } from './inline-engagement.react.js'; import { TooltipInlineEngagement } from './inline-engagement.react.js';
import { InnerRobotextMessage } from './inner-robotext-message.react.js'; import { InnerRobotextMessage } from './inner-robotext-message.react.js';
import { useSendReaction } from './reaction-message-utils.js'; import { useSendReaction } from './reaction-message-utils.js';
▲ Show 20 Lines • Show All 66 Lines • ▼ Show 20 Lines return (
progress={progress} progress={progress}
windowWidth={windowWidth} windowWidth={windowWidth}
initialCoordinates={initialCoordinates} initialCoordinates={initialCoordinates}
/> />
); );
}, [initialCoordinates, isOpeningSidebar, item, progress, windowWidth]); }, [initialCoordinates, isOpeningSidebar, item, progress, windowWidth]);
const { messageInfo, threadInfo, reactions } = item; const { messageInfo, threadInfo, reactions } = item;
const nextLocalID = useSelector(state => state.nextLocalID); const localID = useNextLocalID();
const localID = `${localIDPrefix}${nextLocalID}`;
const canCreateReactionFromMessage = useCanCreateReactionFromMessage( const canCreateReactionFromMessage = useCanCreateReactionFromMessage(
threadInfo, threadInfo,
messageInfo, messageInfo,
); );
const sendReaction = useSendReaction( const sendReaction = useSendReaction(
messageInfo.id, messageInfo.id,
▲ Show 20 Lines • Show All 71 Lines • Show Last 20 Lines