Paths

Table of Contentst

[web] rename getMessageActionTooltipStyle to getTooltipStyle
ClosedPublic
Actions

Authored by ginsu on Aug 16 2023, 6:37 AM.

Details

Reviewers

atul
kamil

Commits

rCOMMfec142e714fa: [web] rename getMessageActionTooltipStyle to getTooltipStyle

Summary

simple rename diff since the functionality of this function can be used for any tooltip not just the message action tooltip

Depends on D8819

Test Plan

flow and confirmed that there were no regressions with the web message tooltip

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Aug 16 2023, 6:37 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 16 2023, 6:37 AM

ginsu edited the summary of this revision. (Show Details)Aug 16 2023, 6:38 AM

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D8819: [web] introduce ReactionPill component.

ginsu added a child revision: D8827: [web] convert createTooltip to getTooltipPositionStyle.Aug 16 2023, 6:44 AM

Harbormaster completed remote builds in B21779: Diff 29933.Aug 16 2023, 6:55 AM

ginsu requested review of this revision.Aug 16 2023, 6:55 AM

kamil accepted this revision.Aug 16 2023, 9:29 AM

This revision is now accepted and ready to land.Aug 16 2023, 9:29 AM

rebase before landing

Harbormaster completed remote builds in B22137: Diff 30383.Aug 28 2023, 4:11 AM

Closed by commit rCOMMfec142e714fa: [web] rename getMessageActionTooltipStyle to getTooltipStyle. · Explain WhyAug 28 2023, 5:04 AM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMfec142e714fa: [web] rename getMessageActionTooltipStyle to getTooltipStyle.

Revision Contents
Changeset List

Path

Size

web/

utils/

tooltip-action-utils.js

4 lines

tooltip-utils.js

12 lines

Diff 30398

View Options

web/utils/tooltip-action-utils.js