Page MenuHomePhabricator
Differential D8826

[web] rename getMessageActionTooltipStyle to getTooltipStyle
ClosedPublic
Actions

Authored by ginsu on Aug 15 2023, 11:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 23, 12:58 PM
Unknown Object (File)
Mon, Mar 17, 4:46 PM
Unknown Object (File)
Mon, Mar 17, 4:46 PM
Unknown Object (File)
Mon, Mar 17, 4:46 PM
Unknown Object (File)
Mon, Mar 17, 4:45 PM
Unknown Object (File)
Mon, Mar 17, 4:24 PM
Unknown Object (File)
Sat, Mar 8, 10:52 AM
Unknown Object (File)
Sat, Mar 1, 4:38 PM
View All 85 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMMfec142e714fa: [web] rename getMessageActionTooltipStyle to getTooltipStyle
Summary

simple rename diff since the functionality of this function can be used for any tooltip not just the message action tooltip

Depends on D8819

Test Plan

flow and confirmed that there were no regressions with the web message tooltip

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Aug 15 2023, 11:37 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 15 2023, 11:37 PM
ginsu edited the summary of this revision. (Show Details)Aug 15 2023, 11:38 PM
ginsu added reviewers: atul, kamil.
ginsu added a parent revision: D8819: [web] introduce ReactionPill component.
ginsu added a child revision: D8827: [web] convert createTooltip to getTooltipPositionStyle.Aug 15 2023, 11:44 PM
Harbormaster completed remote builds in B21779: Diff 29933.Aug 15 2023, 11:55 PM
ginsu requested review of this revision.Aug 15 2023, 11:55 PM
kamil accepted this revision.Aug 16 2023, 2:29 AM
This revision is now accepted and ready to land.Aug 16 2023, 2:29 AM
ginsu updated this revision to Diff 30383.Aug 27 2023, 8:55 PM

rebase before landing

Harbormaster completed remote builds in B22137: Diff 30383.Aug 27 2023, 9:11 PM
Closed by commit rCOMMfec142e714fa: [web] rename getMessageActionTooltipStyle to getTooltipStyle (authored by ginsu). · Explain WhyAug 27 2023, 10:04 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMfec142e714fa: [web] rename getMessageActionTooltipStyle to getTooltipStyle.

Revision Contents
Changeset List

PathSize
web/
utils/
4 lines
12 lines

Diff 30398

View Options

web/utils/tooltip-action-utils.js

Show All 16 Lines
import { isComposableMessageType } from 'lib/types/message-types.js'; import { isComposableMessageType } from 'lib/types/message-types.js';
import { threadPermissions } from 'lib/types/thread-permission-types.js'; import { threadPermissions } from 'lib/types/thread-permission-types.js';
import type { ThreadInfo } from 'lib/types/thread-types.js'; import type { ThreadInfo } from 'lib/types/thread-types.js';
import { longAbsoluteDate } from 'lib/utils/date-utils.js'; import { longAbsoluteDate } from 'lib/utils/date-utils.js';
import { import {
type MessageTooltipAction, type MessageTooltipAction,
findTooltipPosition, findTooltipPosition,
getMessageActionTooltipStyle, getTooltipStyle,
calculateTooltipSize, calculateTooltipSize,
type TooltipSize, type TooltipSize,
type TooltipPosition, type TooltipPosition,
} from './tooltip-utils.js'; } from './tooltip-utils.js';
import { getComposedMessageID } from '../chat/chat-constants.js'; import { getComposedMessageID } from '../chat/chat-constants.js';
import { useEditModalContext } from '../chat/edit-message-provider.js'; import { useEditModalContext } from '../chat/edit-message-provider.js';
import MessageTooltip from '../chat/message-tooltip.react.js'; import MessageTooltip from '../chat/message-tooltip.react.js';
import type { PositionInfo } from '../chat/position-types.js'; import type { PositionInfo } from '../chat/position-types.js';
▲ Show 20 Lines • Show All 302 Lines • ▼ Show 20 Lines const tooltipPosition = findTooltipPosition({
availablePositions, availablePositions,
defaultPosition: availablePositions[0], defaultPosition: availablePositions[0],
preventDisplayingBelowSource: containsInlineEngagement, preventDisplayingBelowSource: containsInlineEngagement,
}); });
if (!tooltipPosition) { if (!tooltipPosition) {
return undefined; return undefined;
} }
const tooltipPositionStyle = getMessageActionTooltipStyle({ const tooltipPositionStyle = getTooltipStyle({
tooltipPosition, tooltipPosition,
sourcePositionInfo: tooltipMessagePosition, sourcePositionInfo: tooltipMessagePosition,
tooltipSize, tooltipSize,
}); });
const tooltip = ( const tooltip = (
<MessageTooltip <MessageTooltip
actions={tooltipActions} actions={tooltipActions}
▲ Show 20 Lines • Show All 135 Lines • Show Last 20 Lines
View Options

web/utils/tooltip-utils.js

Show First 20 Lines • Show All 168 Lines • ▼ Show 20 Lines ) {
canBeDisplayedOnBottom canBeDisplayedOnBottom
) { ) {
return tooltipPosition; return tooltipPosition;
} }
} }
return defaultPosition; return defaultPosition;
} }
type GetMessageActionTooltipStyleParams = { type GetTooltipStyleParams = {
+sourcePositionInfo: PositionInfo, +sourcePositionInfo: PositionInfo,
+tooltipSize: TooltipSize, +tooltipSize: TooltipSize,
+tooltipPosition: TooltipPosition, +tooltipPosition: TooltipPosition,
}; };
// ESLint doesn't recognize that invariant always throws // ESLint doesn't recognize that invariant always throws
// eslint-disable-next-line consistent-return // eslint-disable-next-line consistent-return
function getMessageActionTooltipStyle({ function getTooltipStyle({
sourcePositionInfo, sourcePositionInfo,
tooltipSize, tooltipSize,
tooltipPosition, tooltipPosition,
}: GetMessageActionTooltipStyleParams): TooltipPositionStyle { }: GetTooltipStyleParams): TooltipPositionStyle {
if (tooltipPosition === tooltipPositions.RIGHT_TOP) { if (tooltipPosition === tooltipPositions.RIGHT_TOP) {
return { return {
anchorPoint: { anchorPoint: {
x: sourcePositionInfo.right, x: sourcePositionInfo.right,
y: sourcePositionInfo.top, y: sourcePositionInfo.top,
}, },
horizontalPosition: 'right', horizontalPosition: 'right',
verticalPosition: 'bottom', verticalPosition: 'bottom',
▲ Show 20 Lines • Show All 114 Lines • ▼ Show 20 Lines const height =
tooltipStyle.rowGap * 2 + tooltipStyle.rowGap * 2 +
tooltipButtonStyle.height; tooltipButtonStyle.height;
return { return {
width, width,
height, height,
}; };
} }
export { export { findTooltipPosition, calculateTooltipSize, getTooltipStyle };
findTooltipPosition,
calculateTooltipSize,
getMessageActionTooltipStyle,
};