Page MenuHomePhabricator

[web] introduce functionality to send a reaction by clicking on the reaction pill
ClosedPublic

Authored by ginsu on Aug 14 2023, 9:44 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 1, 1:25 PM
Unknown Object (File)
Mon, Oct 28, 7:45 AM
Unknown Object (File)
Mon, Oct 28, 7:45 AM
Unknown Object (File)
Mon, Oct 28, 7:45 AM
Unknown Object (File)
Mon, Oct 28, 7:45 AM
Unknown Object (File)
Mon, Oct 28, 7:43 AM
Unknown Object (File)
Oct 4 2024, 3:50 PM
Unknown Object (File)
Oct 2 2024, 6:46 PM
Subscribers

Details

Summary

To improve the user experience of the InlineEngagement component we are updating the clicking behavior for our reaction pills. Before whenever a user would click on a reaction, the MessageReactionsModal would pop up, but now if a user clicks a reaction pill they will react/unreact to that message depending on whether or not they have already reacted to that message already. To view the MessageReactionsModal the user now needs to hover on the reaction pill and click on the popup (a similar pattern with other chat apps such as discord and slack), and that functionality will be handled in subsequent diffs

Depends on D8807

Test Plan

Please watch the demo below:

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This revision is now accepted and ready to land.Aug 16 2023, 2:15 AM