[web] introduce useTooltip hook
ClosedPublic
Actions

Authored by ginsu on Aug 16 2023, 12:10 AM.

Details

Reviewers

atul
rohan
kamil

Commits

rCOMM037b2664951a: [web] introduce useTooltip hook

Summary

This diff introduces a hook named useTooltip which is a hook that any tooltip can use (even ones we introduce in the future) and handles all the common core functionality for tooltips. To build this hook, I factored out all the message tooltip specific code and left that in the useMessageTooltip hook and moved over all the tooltip agnostic code into useTooltip

Depends on D8828

Test Plan

flow and confimred that the message tooltip still works and behaves as expected

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Aug 16 2023, 12:10 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 16 2023, 12:10 AM

ginsu edited the summary of this revision. (Show Details)Aug 16 2023, 12:13 AM

ginsu added reviewers: atul, kamil.

ginsu added a parent revision: D8828: [web] move getTooltipPositionStyle into tooltip-utils.

fix types to be read only

ginsu added a child revision: D8831: [web] update calculateMaxTextWidth to consider different font sizes.Aug 16 2023, 12:26 AM

Harbormaster completed remote builds in B21782: Diff 29936.Aug 16 2023, 12:28 AM

Harbormaster completed remote builds in B21783: Diff 29937.Aug 16 2023, 12:37 AM

ginsu requested review of this revision.Aug 16 2023, 12:37 AM

looks good, but not really familiar with the tooltip code

@ginsu please use git blame and arc cover in the future when determining reviewers – it seems clear that @rohan is your best bet here

Seams reasonable, but I don't really have much experience with tooltip (arc cover seems to show I've made the most modifications since I basically just moved code around to prevent a circular dependency in D7308's stack). Would defer to someone more knowledge for the final review