Page MenuHomePhabricator
Differential D8807

[lib/native/web] factor out localID logic into helper hook
ClosedPublic
Actions

Authored by ginsu on Aug 14 2023, 9:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 17, 4:46 PM
Unknown Object (File)
Mon, Mar 17, 4:46 PM
Unknown Object (File)
Mon, Mar 17, 4:46 PM
Unknown Object (File)
Mon, Mar 17, 4:45 PM
Unknown Object (File)
Mon, Mar 17, 4:24 PM
Unknown Object (File)
Thu, Mar 13, 3:56 AM
Unknown Object (File)
Thu, Mar 6, 2:41 PM
Unknown Object (File)
Wed, Feb 26, 1:04 AM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
kamil
Commits
rCOMMdd35f6aeead5: [lib/native/web] factor out localID logic into helper hook
Summary

Refactor diff to reduce tech debt when it came to building the localID for a message.

Addresses https://linear.app/comm/issue/ENG-2852/factor-out-localid-logic-into-helper-functionhook

Depends on D8711

Test Plan

flow and confirmed that there were no regressions when sending a message

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Aug 14 2023, 9:36 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptAug 14 2023, 9:36 AM
ginsu edited the summary of this revision. (Show Details)Aug 14 2023, 9:37 AM
ginsu added reviewers: atul, kamil.
ginsu edited the summary of this revision. (Show Details)
ginsu added a parent revision: D8711: [web] move reaction message action type logic into useSendReaction.
ginsu added a child revision: D8808: [web] introduce functionality to send a reaction by clicking on the reaction pill.Aug 14 2023, 9:48 AM
Harbormaster completed remote builds in B21731: Diff 29865.Aug 14 2023, 9:56 AM
ginsu requested review of this revision.Aug 14 2023, 9:56 AM
kamil accepted this revision.Aug 16 2023, 2:12 AM
This revision is now accepted and ready to land.Aug 16 2023, 2:12 AM
ginsu updated this revision to Diff 30369.Aug 27 2023, 7:52 PM

rebase before landing

Harbormaster completed remote builds in B22133: Diff 30369.Aug 27 2023, 8:10 PM
Closed by commit rCOMMdd35f6aeead5: [lib/native/web] factor out localID logic into helper hook (authored by ginsu). · Explain WhyAug 27 2023, 8:34 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMdd35f6aeead5: [lib/native/web] factor out localID logic into helper hook.

Revision Contents
Changeset List

Diff 30379

View Options

lib/shared/message-utils.js

Loading...
View Options

native/chat/chat-input-bar.react.js

Loading...
View Options

native/chat/inline-engagement.react.js

Loading...
View Options

native/chat/multimedia-message-tooltip-button.react.js

Loading...
View Options

native/chat/robotext-message-tooltip-button.react.js

Loading...
View Options

native/chat/text-message-tooltip-button.react.js

Loading...
View Options

native/input/input-state-container.react.js

Loading...
View Options

web/chat/message-tooltip.react.js

Loading...