Differential D8807 Authored by ginsu on Aug 14 2023, 9:36 AM.
Details Summary Refactor diff to reduce tech debt when it came to building the localID for a message. Addresses https://linear.app/comm/issue/ENG-2852/factor-out-localid-logic-into-helper-functionhook Depends on D8711 Test Plan flow and confirmed that there were no regressions when sending a message
Diff Detail
Event TimelineHerald added subscribers: tomek, ashoat. · View Herald TranscriptAug 14 2023, 9:36 AM2023-08-14 09:36:05 (UTC-7) ginsu edited the summary of this revision. (Show Details)Aug 14 2023, 9:37 AM2023-08-14 09:37:44 (UTC-7) ginsu added a parent revision: D8711: [web] move reaction message action type logic into useSendReaction. Harbormaster completed remote builds in B21731: Diff 29865.Aug 14 2023, 9:56 AM2023-08-14 09:56:13 (UTC-7) This revision is now accepted and ready to land.Aug 16 2023, 2:12 AM2023-08-16 02:12:05 (UTC-7) Harbormaster completed remote builds in B22133: Diff 30369.Aug 27 2023, 8:10 PM2023-08-27 20:10:08 (UTC-7) Closed by commit rCOMMdd35f6aeead5: [lib/native/web] factor out localID logic into helper hook (authored by ginsu). · Explain WhyAug 27 2023, 8:34 PM2023-08-27 20:34:46 (UTC-7) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 30379 |