Page MenuHomePhabricator

[web] move reaction message action type logic into useSendReaction
ClosedPublic

Authored by ginsu on Aug 2 2023, 12:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Oct 28, 7:45 AM
Unknown Object (File)
Mon, Oct 28, 7:45 AM
Unknown Object (File)
Mon, Oct 28, 7:45 AM
Unknown Object (File)
Mon, Oct 28, 7:45 AM
Unknown Object (File)
Mon, Oct 28, 7:43 AM
Unknown Object (File)
Sep 28 2024, 8:52 AM
Unknown Object (File)
Sep 24 2024, 12:37 AM
Unknown Object (File)
Sep 21 2024, 8:54 PM
Subscribers

Details

Summary

This diff brings in the logic which determines if we are reacting or unreacting to a message into the useSendReaction hook. I don't know why we didn't do this initially, but this diff resolves this and will make it so we don't need to copy/paste this logic when we call useSendReaction with the InlineEngagement

Depends on D8710

Test Plan

flow and confirmed that I can still react and unreact to messages

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu published this revision for review.Aug 2 2023, 12:31 PM
ginsu edited the summary of this revision. (Show Details)
ginsu added reviewers: atul, kamil.
This revision is now accepted and ready to land.Aug 3 2023, 9:36 PM