Page MenuHomePhabricator

[web] move reaction message action type logic into useSendReaction
ClosedPublic

Authored by ginsu on Aug 2 2023, 12:30 PM.
Tags
None
Referenced Files
F2017363: D8711.diff
Sat, Jun 15, 1:46 PM
Unknown Object (File)
Sun, Jun 9, 4:57 PM
Unknown Object (File)
Sun, Jun 2, 10:59 PM
Unknown Object (File)
Sun, Jun 2, 10:59 PM
Unknown Object (File)
Sun, Jun 2, 10:58 PM
Unknown Object (File)
Thu, May 30, 11:15 PM
Unknown Object (File)
Sun, May 26, 10:06 AM
Unknown Object (File)
Wed, May 22, 9:30 AM
Subscribers

Details

Summary

This diff brings in the logic which determines if we are reacting or unreacting to a message into the useSendReaction hook. I don't know why we didn't do this initially, but this diff resolves this and will make it so we don't need to copy/paste this logic when we call useSendReaction with the InlineEngagement

Depends on D8710

Test Plan

flow and confirmed that I can still react and unreact to messages

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu published this revision for review.Aug 2 2023, 12:31 PM
ginsu edited the summary of this revision. (Show Details)
ginsu added reviewers: atul, kamil.
This revision is now accepted and ready to land.Aug 3 2023, 9:36 PM