Page Menu
Home
Phorge
Search
Configure Global Search
Log In
Files
F33044671
D9497.1768417755.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Flag For Later
Award Token
Size
3 KB
Referenced Files
None
Subscribers
None
D9497.1768417755.diff
View Options
diff --git a/web/media/multimedia-modal.react.js b/web/media/multimedia-modal.react.js
--- a/web/media/multimedia-modal.react.js
+++ b/web/media/multimedia-modal.react.js
@@ -130,8 +130,8 @@
const multimediaModal = React.useMemo(
() => (
<FullScreenViewModal
- contentDimensions={dimensions}
- setContentDimensions={setDimensions}
+ dynamicContentDimensions={dimensions}
+ setDynamicContentDimensions={setDimensions}
>
{mediaModalItem}
</FullScreenViewModal>
diff --git a/web/modals/full-screen-view-modal.react.js b/web/modals/full-screen-view-modal.react.js
--- a/web/modals/full-screen-view-modal.react.js
+++ b/web/modals/full-screen-view-modal.react.js
@@ -12,8 +12,8 @@
type BaseProps = {
+children: React.Node,
- +contentDimensions: ?Dimensions,
- +setContentDimensions: SetState<?Dimensions>,
+ +dynamicContentDimensions?: ?Dimensions,
+ +setDynamicContentDimensions?: SetState<?Dimensions>,
};
type Props = {
@@ -27,12 +27,15 @@
componentDidMount() {
invariant(this.overlay, 'overlay ref unset');
this.overlay.focus();
- this.calculateMediaDimensions();
- window.addEventListener('resize', this.calculateMediaDimensions);
+ this.calculateDynamicContentDimensions();
+ window.addEventListener('resize', this.calculateDynamicContentDimensions);
}
componentWillUnmount() {
- window.removeEventListener('resize', this.calculateMediaDimensions);
+ window.removeEventListener(
+ 'resize',
+ this.calculateDynamicContentDimensions,
+ );
}
render(): React.Node {
@@ -75,27 +78,36 @@
}
};
- calculateMediaDimensions: () => void = () => {
- if (!this.overlay || !this.props.contentDimensions) {
+ calculateDynamicContentDimensions: () => mixed = () => {
+ const { dynamicContentDimensions, setDynamicContentDimensions } =
+ this.props;
+
+ if (
+ !this.overlay ||
+ !dynamicContentDimensions ||
+ !setDynamicContentDimensions
+ ) {
return;
}
+
const containerWidth = this.overlay.clientWidth;
const containerHeight = this.overlay.clientHeight;
const containerAspectRatio = containerWidth / containerHeight;
- const { width: mediaWidth, height: mediaHeight } =
- this.props.contentDimensions;
- const mediaAspectRatio = mediaWidth / mediaHeight;
+ const { width: contentWidth, height: contentHeight } =
+ dynamicContentDimensions;
+ const contentAspectRatio = contentWidth / contentHeight;
let newWidth, newHeight;
- if (containerAspectRatio > mediaAspectRatio) {
- newWidth = Math.min(mediaWidth, containerHeight * mediaAspectRatio);
- newHeight = newWidth / mediaAspectRatio;
+ if (containerAspectRatio > contentAspectRatio) {
+ newWidth = Math.min(contentWidth, containerHeight * contentAspectRatio);
+ newHeight = newWidth / contentAspectRatio;
} else {
- newHeight = Math.min(mediaHeight, containerWidth / mediaAspectRatio);
- newWidth = newHeight * mediaAspectRatio;
+ newHeight = Math.min(contentHeight, containerWidth / contentAspectRatio);
+ newWidth = newHeight * contentAspectRatio;
}
- this.props.setContentDimensions({
+
+ setDynamicContentDimensions({
width: newWidth,
height: newHeight,
});
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Jan 14, 7:09 PM (12 h, 28 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
5930378
Default Alt Text
D9497.1768417755.diff (3 KB)
Attached To
Mode
D9497: [web] make FullScreenViewModal completly generic
Attached
Detach File
Event Timeline
Log In to Comment