Page MenuHomePhabricator
Differential D9497

[web] make FullScreenViewModal completly generic
ClosedPublic
Actions

Authored by ginsu on Oct 15 2023, 9:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Jun 30, 12:38 AM
Unknown Object (File)
Sat, Jun 29, 7:05 PM
Unknown Object (File)
Sat, Jun 29, 4:37 AM
Unknown Object (File)
Sat, Jun 29, 4:37 AM
Unknown Object (File)
Sat, Jun 29, 4:37 AM
Unknown Object (File)
Sat, Jun 29, 4:37 AM
Unknown Object (File)
Sat, Jun 29, 4:35 AM
Unknown Object (File)
Sat, Jun 29, 1:47 AM
View All 55 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMM61c544fcfc3e: [web] make FullScreenViewModal completly generic
Summary

This is a simple rename diff to make FullScreenViewModal completely generic

This is step 3 in the list below
Outlined below are the steps I will take in this stack (each point here will be it's own diff):

  1. Introduce FullScreenViewModal file and move everything from the ImageModal file into here, and change what is absolutely necessary (the imports)
  2. Lift the rendering of mediaModalItem out of FullScreenViewModal
  3. Finish renaming + updating remaining variables/callbacks to make FullScreenViewModal completly generic
  4. Introduce UserProfileAvatarModal

Part of this linear task: https://linear.app/comm/issue/ENG-5201/factor-out-viewing-image-multimedia-messages-specific-code-from

Depends on D9496

Test Plan

Confirmed that there were no regressions with viewing a multimedia message in a full screen view

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 15 2023, 9:11 PM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 15 2023, 9:11 PM
ginsu edited the summary of this revision. (Show Details)Oct 15 2023, 9:16 PM
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D9496: [web] factor out mediaModalItem from FullScreenModal.
ginsu updated this revision to Diff 32011.Oct 15 2023, 9:25 PM

update

Harbormaster completed remote builds in B23252: Diff 32008.Oct 15 2023, 9:29 PM
Harbormaster completed remote builds in B23255: Diff 32011.Oct 15 2023, 9:43 PM
ginsu requested review of this revision.Oct 15 2023, 9:43 PM
ginsu added a child revision: D9498: [web] introduce UserProfileAvatarModal.Oct 15 2023, 9:51 PM
atul accepted this revision.Oct 16 2023, 5:06 PM

Didn't read carefully, trusting that it's a simple find/replace diff

This revision is now accepted and ready to land.Oct 16 2023, 5:06 PM
ginsu updated this revision to Diff 32109.Oct 17 2023, 2:25 PM

rebase before landing

Harbormaster completed remote builds in B23314: Diff 32109.Oct 17 2023, 2:43 PM
Closed by commit rCOMM61c544fcfc3e: [web] make FullScreenViewModal completly generic (authored by ginsu). · Explain WhyOct 17 2023, 2:53 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM61c544fcfc3e: [web] make FullScreenViewModal completly generic.

Revision Contents
Changeset List

PathSize
web/
media/
4 lines
modals/
44 lines

Diff 32124

View Options

web/media/multimedia-modal.react.js

Loading...
View Options

web/modals/full-screen-view-modal.react.js

Loading...