Page MenuHomePhabricator

[web] introduce UserProfileAvatarModal
ClosedPublic

Authored by ginsu on Oct 15 2023, 9:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jul 1, 4:45 AM
Unknown Object (File)
Sat, Jun 29, 4:37 AM
Unknown Object (File)
Sat, Jun 29, 4:37 AM
Unknown Object (File)
Sat, Jun 29, 4:37 AM
Unknown Object (File)
Sat, Jun 29, 4:35 AM
Unknown Object (File)
Sat, Jun 29, 1:47 AM
Unknown Object (File)
Thu, Jun 27, 11:46 PM
Unknown Object (File)
Wed, Jun 26, 9:11 AM
Subscribers

Details

Summary

In this diff we introduce the UserProfileAvatarModal and we add an onClick callback to the user avatar which pushes this modal whenever the onClick callback gets triggered

This is step 4 in the list below
Outlined below are the steps I will take in this stack (each point here will be it's own diff):

  1. Introduce FullScreenViewModal file and move everything from the ImageModal file into here, and change what is absolutely necessary (the imports)
  2. Lift the rendering of mediaModalItem out of FullScreenViewModal
  3. Finish renaming + updating remaining variables/callbacks to make FullScreenViewModal completly generic
  4. Introduce UserProfileAvatarModal

Linear Task: https://linear.app/comm/issue/ENG-5202/introduce-fullscreenavatarviewmodal

Depends on D9497

Test Plan

Please see the demo video below

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka.
ginsu requested review of this revision.Oct 15 2023, 9:58 PM
atul added inline comments.
web/modals/user-profile/user-profile-avatar-modal.react.js
16–18 ↗(On Diff #32012)

Doesn't hurt to memoize

This revision is now accepted and ready to land.Oct 17 2023, 9:20 AM

address @atul's comments + rebase before landing

This revision was automatically updated to reflect the committed changes.