Paths

Table of Contentst

Differential D9477

[web] make user profile accessible from friend/block list row
ClosedPublic
Actions

Authored by ginsu on Oct 12 2023, 10:13 PM.

Tags

None

Referenced Files

	F2191171: D9477.id32091.diff
	Thu, Jul 4, 2:16 PM

	F2186252: D9477.id32114.diff
	Thu, Jul 4, 2:37 AM

	Unknown Object (File)
	Wed, Jul 3, 10:09 AM

	Unknown Object (File)
	Tue, Jul 2, 5:37 PM

	Unknown Object (File)
	Mon, Jul 1, 2:06 PM

	Unknown Object (File)
	Mon, Jul 1, 3:02 AM

	Unknown Object (File)
	Sun, Jun 30, 10:05 PM

	Unknown Object (File)
	Sun, Jun 30, 8:36 PM

View All 59 Files

Subscribers

Details

Reviewers

atul
inka

Commits

rCOMM040c3d3d9c56: [web] make user profile accessible from friend/block list row

Summary

This diff makes the friend/block list row item interactive. When a user clicks on this component, the user profile modal will be pushed

Linear task:
https://linear.app/comm/issue/ENG-5238/make-user-profile-accessible-from-friend-list-row
https://linear.app/comm/issue/ENG-5239/make-user-profile-accessible-from-block-list-row

Depends on D9476

Test Plan

Please see the demo video below:

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 12 2023, 10:13 PM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 12 2023, 10:13 PM

update

ginsu edited the summary of this revision. (Show Details)Oct 12 2023, 10:29 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D9476: [web] introduce usePushUserProfileModal hook.

ginsu attached a referenced file: F811711: Screen Recording 2023-10-13 at 1.29.00 AM.mov. (Show Details)

Harbormaster completed remote builds in B23226: Diff 31982.Oct 12 2023, 10:30 PM

ginsu added a subscriber: • ted.Oct 12 2023, 10:35 PM

ginsu added inline comments.

web/settings/relationship/friend-list-row.react.js
28 ↗	(On Diff #31983)	We need to call `stopPropagation` so that the callback of the action button and the container don't fire off at the same time https://developer.mozilla.org/en-US/docs/Web/API/Event/stopPropagation
web/settings/relationship/user-list-row.css
12 ↗	(On Diff #31983)	Instead of creating a new color variable, I reused one with an incorrect variable name. I made a comment in the Linear task responsible for this part of the new color design system on web project and @ted and I will address this then. https://linear.app/comm/issue/ENG-4805/relationship-friendblock-list#comment-5f5d7de3

ginsu added a child revision: D9481: [web] make user profile accessible from message author avatar + name.Oct 12 2023, 10:40 PM

Harbormaster completed remote builds in B23227: Diff 31983.Oct 12 2023, 10:46 PM

ginsu requested review of this revision.Oct 12 2023, 10:46 PM

ginsu mentioned this in D9483: [web] make user profile accessible from member component.Oct 12 2023, 11:05 PM

Kind of looked like the height of the highlighted "cell" area changed when friend request was cancelled and the cell with icon took its place. Can you take a look and create an issue before landing if it's a real issue

This revision is now accepted and ready to land.Oct 16 2023, 11:43 AM

https://linear.app/comm/issue/ENG-5279/the-friendblock-list-row-component-does-not-have-a-consistent-height

rebase before landing

rebase before landing

Harbormaster completed remote builds in B23296: Diff 32091.Oct 17 2023, 11:52 AM

Harbormaster completed remote builds in B23300: Diff 32095.Oct 17 2023, 12:09 PM

Closed by commit rCOMM040c3d3d9c56: [web] make user profile accessible from friend/block list row (authored by ginsu). · Explain WhyOct 17 2023, 2:53 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM040c3d3d9c56: [web] make user profile accessible from friend/block list row.

Revision Contents
Changeset List

Path

Size

web/

settings/

relationship/

block-list-row.react.js

5 lines

friend-list-row.react.js

37 lines

user-list-row.css

10 lines

Diff 32114

web/settings/relationship/block-list-row.react.js

Loading...

web/settings/relationship/friend-list-row.react.js

Loading...

web/settings/relationship/user-list-row.css

Loading...