[web] introduce usePushUserProfileModal hook
ClosedPublic
Actions

Authored by ginsu on Oct 12 2023, 9:45 PM.

Details

Reviewers

atul
inka

Commits

rCOMM0802a4c4291c: [web] introduce usePushUserProfileModal hook

Summary

This diff introduces usePushUserProfileModal hook which is going to be used to push the user profile modal. This logic will need to be repeated in every place we want the user profiles to be accessible, so I thought that instead of copy+pasting the logic we should preemptively factor out this logic into this helper hook.

Linear task: https://linear.app/comm/issue/ENG-5246/introduce-hook-to-push-user-profile-modal

Test Plan

Confirmed that I can push the user profile modal (the subsequent diffs will have the demo videos for each of the access points)

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 12 2023, 9:45 PM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 12 2023, 9:45 PM

ginsu edited the summary of this revision. (Show Details)Oct 12 2023, 9:48 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

Harbormaster returned this revision to the author for changes because remote builds failed.Oct 12 2023, 10:01 PM

Harbormaster failed remote builds in B23224: Diff 31980!

rebase

ginsu added a child revision: D9477: [web] make user profile accessible from friend/block list row.Oct 12 2023, 10:29 PM

Harbormaster completed remote builds in B23225: Diff 31981.Oct 12 2023, 10:30 PM

ginsu requested review of this revision.Oct 12 2023, 10:30 PM

atul accepted this revision.Oct 16 2023, 11:26 AM

atul added inline comments.

web/modals/user-profile/user-profile-utils.js
9 ↗	(On Diff #31981)	Let's pull this out as `Props` type and mark as read-only for for consistency. If it leads to annoying merge conflicts/rebasing, feel free to add to end of stack as followup before landing this.