Page MenuHomePhabricator
Differential D9485

[web] introduce MessageReactionsListItem
ClosedPublic
Actions

Authored by ginsu on Oct 12 2023, 11:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jul 3, 7:35 AM
Unknown Object (File)
Mon, Jul 1, 7:07 AM
Unknown Object (File)
Sat, Jun 29, 10:49 PM
Unknown Object (File)
Sat, Jun 29, 5:03 PM
Unknown Object (File)
Sat, Jun 29, 4:07 AM
Unknown Object (File)
Sat, Jun 29, 4:07 AM
Unknown Object (File)
Sat, Jun 29, 4:07 AM
Unknown Object (File)
Sat, Jun 29, 4:04 AM
View All 38 Files
Subscribers
ashoat
tomek
will

Details

Reviewers
atul
inka
Commits
rCOMM00a67be61403: [web] introduce MessageReactionsListItem
Summary

This diff simply factors out the logic of rendering the message reactions list item into it's own component. We want to do this so that we can use usePushUserProfileModal inside this component

Part of https://linear.app/comm/issue/ENG-5244/make-user-profile-accessible-from-message-reactions-modal

Depends on D9484

Test Plan

Confirmed that the message reactions modal still looks and behaves the same

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 12 2023, 11:16 PM
Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 12 2023, 11:16 PM
ginsu edited the summary of this revision. (Show Details)Oct 12 2023, 11:17 PM
ginsu added reviewers: atul, inka.
ginsu added a parent revision: D9484: [web] make user profile accessible from user entity robotext.
ginsu added a child revision: D9486: [web] make user profile accessible from message reactions list item.Oct 12 2023, 11:29 PM
Harbormaster completed remote builds in B23235: Diff 31991.Oct 12 2023, 11:33 PM
ginsu requested review of this revision.Oct 12 2023, 11:33 PM
atul accepted this revision.Oct 16 2023, 12:16 PM
atul added inline comments.
web/modals/chat/message-reactions-list-item.react.js
18–24 ↗(On Diff #31991)

Doesn't hurt to memoize to avoid re-rendering UserAvatar, etc

This revision is now accepted and ready to land.Oct 16 2023, 12:16 PM
ginsu updated this revision to Diff 32099.Oct 17 2023, 11:57 AM

address @atul's comments + rebase before landing

Harbormaster completed remote builds in B23304: Diff 32099.Oct 17 2023, 12:18 PM
Closed by commit rCOMM00a67be61403: [web] introduce MessageReactionsListItem (authored by ginsu). · Explain WhyOct 17 2023, 2:53 PM
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM00a67be61403: [web] introduce MessageReactionsListItem.

Revision Contents
Changeset List

PathSize
lib/
shared/
2 lines
web/
modals/
chat/
37 lines
13 lines

Diff 32118

View Options

lib/shared/reaction-utils.js

Loading...
View Options

web/modals/chat/message-reactions-list-item.react.js

Loading...
View Options

web/modals/chat/message-reactions-modal.react.js

Loading...