Page MenuHomePhabricator

[web] introduce FullScreenViewModal
ClosedPublic

Authored by ginsu on Oct 15 2023, 8:42 PM.
Tags
None
Referenced Files
F2193545: D9495.id32009.diff
Thu, Jul 4, 10:27 PM
Unknown Object (File)
Wed, Jul 3, 2:58 AM
Unknown Object (File)
Wed, Jul 3, 12:04 AM
Unknown Object (File)
Sat, Jun 29, 4:07 AM
Unknown Object (File)
Sat, Jun 29, 4:07 AM
Unknown Object (File)
Sat, Jun 29, 4:07 AM
Unknown Object (File)
Sat, Jun 29, 4:07 AM
Unknown Object (File)
Sat, Jun 29, 4:07 AM
Subscribers

Details

Summary

To view a full screen avatar for user profiles we are going to want to reuse parts of the MultimediaModal component.

However, right now there are parts of MultimediaModal that are specific to viewing a multimedia message. We need to factor those parts out, so I created FullScreenViewModal which will be a generic component that can be used in both cases for image multimedia messages and user avatars.

Outlined below are the steps I will take in this stack (each point here will be it's own diff):

  1. Introduce FullScreenViewModal file and move everything from the ImageModal file into here, and change what is absolutely necessary (the imports)
  2. Lift the rendering of mediaModalItem out of FullScreenViewModal
  3. Finish renaming + updating remaining variables/callbacks to make FullScreenViewModal completly generic
  4. Introduce UserProfileAvatarModal

Linear Task: https://linear.app/comm/issue/ENG-5200/introduce-generic-fullscreenviewmodal

Depends on D9488

Test Plan

Confirmed that there were no regressions with the viewing a multimedia message in a full screen view

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu added reviewers: atul, inka.
ginsu edited the summary of this revision. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 15 2023, 8:58 PM
Harbormaster failed remote builds in B23248: Diff 32004!
Harbormaster returned this revision to the author for changes because remote builds failed.Oct 15 2023, 9:16 PM
Harbormaster failed remote builds in B23250: Diff 32006!
ginsu requested review of this revision.Oct 15 2023, 9:39 PM

Looks like a reasonable approach

This revision is now accepted and ready to land.Oct 16 2023, 12:39 PM
This revision was automatically updated to reflect the committed changes.