Differential D9483

[web] make user profile accessible from member component
ClosedPublic
Actions

Authored by ginsu on Oct 12 2023, 10:57 PM.

Tags

None

Referenced Files

	F2193330: D9483.id32097.diff
	Thu, Jul 4, 9:46 PM

	Unknown Object (File)
	Tue, Jul 2, 7:32 PM

	Unknown Object (File)
	Mon, Jul 1, 1:18 AM

	Unknown Object (File)
	Sat, Jun 29, 6:46 PM

	Unknown Object (File)
	Sat, Jun 29, 4:37 AM

	Unknown Object (File)
	Sat, Jun 29, 4:37 AM

	Unknown Object (File)
	Sat, Jun 29, 4:37 AM

	Unknown Object (File)
	Sat, Jun 29, 4:34 AM

View All 40 Files

Subscribers

Details

Reviewers

atul
inka

Commits

rCOMMdb43e7778995: [web] make user profile accessible from member component

Summary

This diff makes the member component interactive. When a user clicks on this component, the user profile modal will be pushed

Linear task:

https://linear.app/comm/issue/ENG-5242/make-user-profile-accessible-from-thread-member

Depends on D9481

Test Plan

Please see demo video below:

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Oct 12 2023, 10:57 PM

Herald added subscribers: will, tomek, ashoat. · View Herald TranscriptOct 12 2023, 10:57 PM

ginsu edited the summary of this revision. (Show Details)Oct 12 2023, 11:00 PM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka.

ginsu added a parent revision: D9481: [web] make user profile accessible from message author avatar + name.

ginsu attached a referenced file: F811991: Screen Recording 2023-10-13 at 1.58.24 AM.mov. (Show Details)

ginsu edited the summary of this revision. (Show Details)Oct 12 2023, 11:05 PM

ginsu edited the summary of this revision. (Show Details)

ginsu added a subscriber: • ted.

ginsu added inline comments.

web/modals/threads/members/member.react.js
120–122 ↗	(On Diff #31989)	Removed this so that the component has a hover effect that is consistent with the friend/block list row from D9477
web/modals/threads/members/members-modal.css
37 ↗	(On Diff #31989)	Instead of creating a new color variable, I reused one with an incorrect variable name. I made a comment in the Linear task responsible for this part of the new color design system on web project and @ted and I will address this then. https://linear.app/comm/issue/ENG-5032/thread-members-modal#comment-4e2519b3

ginsu added a child revision: D9484: [web] make user profile accessible from user entity robotext.Oct 12 2023, 11:13 PM

Harbormaster completed remote builds in B23233: Diff 31989.Oct 12 2023, 11:13 PM

ginsu requested review of this revision.Oct 12 2023, 11:13 PM

atul accepted this revision.Oct 16 2023, 11:51 AM

atul added inline comments.

web/modals/threads/members/members-modal.css
37 ↗	(On Diff #31989)	The color also "blends in" with the role label pill. We should either use a slightly different color, add an outline to the pill, etc.

This revision is now accepted and ready to land.Oct 16 2023, 11:51 AM

rebase before landing + address @atul's comments

Harbormaster completed remote builds in B23302: Diff 32097.Oct 17 2023, 12:14 PM

Closed by commit rCOMMdb43e7778995: [web] make user profile accessible from member component (authored by ginsu). · Explain WhyOct 17 2023, 2:53 PM

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMMdb43e7778995: [web] make user profile accessible from member component.

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

members/

member.react.js

11 lines

members-list.react.js

3 lines

members-modal.css

8 lines

Diff 32116

web/modals/threads/members/member.react.js

Loading...

web/modals/threads/members/members-list.react.js

Loading...

web/modals/threads/members/members-modal.css

Loading...