Page MenuHomePhabricator
Files F3376302

D3826.diff
No OneTemporary
Actions

D3826.diff
View Options

diff --git a/web/modals/threads/thread-settings-general-tab.react.js b/web/modals/threads/thread-settings-general-tab.react.js
--- a/web/modals/threads/thread-settings-general-tab.react.js
+++ b/web/modals/threads/thread-settings-general-tab.react.js
@@ -7,15 +7,14 @@
import css from './thread-settings-general-tab.css';
type ThreadSettingsGeneralTabProps = {
+ +inputDisabled: boolean,
+threadNameValue: string,
+threadNamePlaceholder: string,
+threadNameOnChange: (event: SyntheticEvent<HTMLInputElement>) => void,
- +threadNameDisabled: boolean,
+threadDescriptionValue: string,
+threadDescriptionOnChange: (
event: SyntheticEvent<HTMLTextAreaElement>,
) => void,
- +threadDescriptionDisabled: boolean,
+threadColorCurrentColor: string,
+threadColorOnColorSelection: (color: string) => void,
};
@@ -23,13 +22,12 @@
props: ThreadSettingsGeneralTabProps,
): React.Node {
const {
+ inputDisabled,
threadNameValue,
threadNamePlaceholder,
threadNameOnChange,
- threadNameDisabled,
threadDescriptionValue,
threadDescriptionOnChange,
- threadDescriptionDisabled,
threadColorCurrentColor,
threadColorOnColorSelection,
} = props;
@@ -44,7 +42,7 @@
value={threadNameValue}
placeholder={threadNamePlaceholder}
onChange={threadNameOnChange}
- disabled={threadNameDisabled}
+ disabled={inputDisabled}
/>
</div>
</div>
@@ -55,7 +53,7 @@
value={threadDescriptionValue}
placeholder="Thread description"
onChange={threadDescriptionOnChange}
- disabled={threadDescriptionDisabled}
+ disabled={inputDisabled}
/>
</div>
</div>
diff --git a/web/modals/threads/thread-settings-modal.react.js b/web/modals/threads/thread-settings-modal.react.js
--- a/web/modals/threads/thread-settings-modal.react.js
+++ b/web/modals/threads/thread-settings-modal.react.js
@@ -287,17 +287,16 @@
if (currentTabType === 'general') {
mainContent = (
<ThreadSettingsGeneralTab
+ inputDisabled={inputDisabled}
threadNameValue={firstLine(
queuedChanges['name'] ?? threadInfo['name'],
)}
threadNamePlaceholder={namePlaceholder}
threadNameOnChange={onChangeName}
- threadNameDisabled={inputDisabled}
threadDescriptionValue={
queuedChanges['description'] ?? threadInfo['description'] ?? ''
}
threadDescriptionOnChange={onChangeDescription}
- threadDescriptionDisabled={inputDisabled}
threadColorCurrentColor={
queuedChanges['color'] ?? threadInfo['color']
}

File Metadata

Mime Type
text/plain
Expires
Wed, Nov 27, 11:15 PM (21 h, 28 m)
Storage Engine
blob
Storage Format
Raw Data
Storage Handle
2592039
Default Alt Text
D3826.diff (2 KB)

Event Timeline