These props both get inputDisabled passed in from the parent component, so they can be "flattened" into a single prop.
Depends on D3825
Differential D3826
[web] Remove duplicate `thread[Name/Description]Disabled` props in `ThreadSettingsGeneralTab` component atul on Apr 24 2022, 1:05 PM. Authored by Tags None Referenced Files
Details These props both get inputDisabled passed in from the parent component, so they can be "flattened" into a single prop. Depends on D3825
Diff Detail
Event TimelineComment Actions Just wondering: are we planning to have threads with one input enabled and another disabled? It feels like changing a description is less destructive than changing a name and more users could be allowed to do that. On the other hand, reintroducing this option shouldn't be hard. Adding @ashoat to get his opinion. Comment Actions That's a good point, I could definitely see us having more fine-grained thread setting permissions in the future. For now just maintaining the existing behavior, which I think should be fine for a refactoring stack of diffs. |