Move errorMessage out of the inner class component state, and move it out to the wrapping "Connected" functional component.
As part of the work to refactor ThreadSettingsModal… specifically to turn it into a functional component.
Paths
| Differential D3756 Authored by atul on Apr 18 2022, 10:25 AM.
Details Summary Move errorMessage out of the inner class component state, and move it out to the wrapping "Connected" functional component. As part of the work to refactor ThreadSettingsModal… specifically to turn it into a functional component. Test Plan
Diff Detail
Event TimelineHerald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 18 2022, 10:25 AM2022-04-18 10:25:20 (UTC-7) atul retitled this revision from [web] Use `React.useState('')` for `errorMessage` in `ThreadSettingsModal` to [web] Move `errorMessage` state up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`.Apr 18 2022, 10:26 AM2022-04-18 10:26:15 (UTC-7) Harbormaster completed remote builds in B8262: Diff 11553.Apr 18 2022, 10:30 AM2022-04-18 10:30:17 (UTC-7) Harbormaster completed remote builds in B8263: Diff 11554.Apr 18 2022, 10:37 AM2022-04-18 10:37:32 (UTC-7) atul edited the test plan for this revision. (Show Details)Apr 18 2022, 10:38 AM2022-04-18 10:38:21 (UTC-7) Comment Actions Why is this necessary? Each diff should "stand on its own" and be reviewable without additional context. "As part of the work to refactor ThreadSettingsModal" is not enough of an explanation for me to understand why this state needs to be lifted. If the explanation is in another diff, a simple link to that diff should be enough! This revision now requires changes to proceed.Apr 18 2022, 9:14 PM2022-04-18 21:14:45 (UTC-7) Comment Actions Cool, that's helpful. Please edit the diff description of every diff to include that info! This revision is now accepted and ready to land.Apr 18 2022, 10:02 PM2022-04-18 22:02:40 (UTC-7) This revision was landed with ongoing or failed builds.Apr 19 2022, 11:29 AM2022-04-19 11:29:32 (UTC-7) Closed by commit rCOMM2a11f335d584: [web] Move `errorMessage` state up from `ThreadSettingsModal` to… (authored by atul). · Explain Why This revision was automatically updated to reflect the committed changes. Harbormaster completed remote builds in B8326: Diff 11632.Apr 19 2022, 11:40 AM2022-04-19 11:40:56 (UTC-7)
Revision Contents
Diff 11633 web/modals/threads/thread-settings-modal.react.js
|