HomePhabricator
Diffusion Comm 2a11f335d584

[web] Move `errorMessage` state up from `ThreadSettingsModal` to…

Tags
None
Referenced Files
F40929: 83b8.png
Apr 19 2022, 11:29 AM
Subscribers
None

Description

[web] Move errorMessage state up from ThreadSettingsModal to ConnectedThreadSettingsModal

Summary:
Move errorMessage out of the inner class component state, and move it out to the wrapping "Connected" functional component.

As part of the work to refactor ThreadSettingsModal… specifically to turn it into a functional component.

Test Plan:

  1. Kill the node server
  2. Try to save a change to thead settings
  3. Observe that error message appears as expected

83b8.png (1×712 px, 79 KB)

Note: The error message styling (showing up to the right of the button) isn't great. That's "on the todo list" and will be handled once the "noop" refactorings are complete.

Reviewers: def-au1t, palys-swm, ashoat

Reviewed By: ashoat

Subscribers: ashoat, Adrian, karol-bisztyga, benschac, yayabosh

Differential Revision: https://phabricator.ashoat.com/D3756