Paths

Table of Contentst

Differential D3760

[web] Move `queuedChanges` state up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`
ClosedPublic
Actions

Authored by atul on Apr 18 2022, 11:38 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Tue, Nov 5, 1:47 AM

	Unknown Object (File)
	Sat, Nov 2, 12:29 PM

	Unknown Object (File)
	Thu, Oct 10, 2:51 AM

	Unknown Object (File)
	Thu, Oct 10, 2:51 AM

	Unknown Object (File)
	Thu, Oct 10, 2:51 AM

	Unknown Object (File)
	Thu, Oct 10, 2:51 AM

	Unknown Object (File)
	Thu, Oct 10, 2:50 AM

	Unknown Object (File)
	Thu, Oct 10, 2:48 AM

Subscribers

Details

Reviewers

• jacek
tomek

Commits

rCOMM5c826a4f1daa: [web] Move `queuedChanges` state up from `ThreadSettingsModal` to…

Summary

Move currentTabType state out of the inner class component state, and move it out to the wrapping "Connected" functional component.

As part of the work to refactor ThreadSettingsModal… specifically to turn it into a functional component.

Depends on D3759

Test Plan

Was able to change settings in the ThreadSettingsModal and things continued to look/work as expected.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

atul created this revision.Apr 18 2022, 11:38 AM

Herald added subscribers: • abosh, • benschac, • karol and 2 others. · View Herald TranscriptApr 18 2022, 11:38 AM

atul published this revision for review.Apr 18 2022, 11:39 AM

Harbormaster completed remote builds in B8267: Diff 11558.Apr 18 2022, 11:43 AM

atul added a child revision: D3762: [web] Move `namePlaceholder` up from `ThreadSettingsModal` to `ConnectedThreadSettingsModal`.Apr 18 2022, 12:46 PM

atul edited the summary of this revision. (Show Details)Apr 18 2022, 10:03 PM

tomek accepted this revision.Apr 19 2022, 3:52 AM

tomek added inline comments.

web/modals/threads/thread-settings-modal.react.js
349–352 ↗	(On Diff #11558)	I know this is pure refactor diff, but just wanted to let you know that there's an inconsistency in what we're storing in state. When we clear the state, we set it to `Object.freeze({})`, but when we update it, we no longer freeze. We should either always freeze or never. I think it should be fine to avoid freezing, as `ThreadChanges` has readonly fields.

This revision is now accepted and ready to land.Apr 19 2022, 3:52 AM

rebase before landing

Harbormaster completed remote builds in B8330: Diff 11639.Apr 19 2022, 1:02 PM

atul added inline comments.Apr 19 2022, 2:18 PM

web/modals/threads/thread-settings-modal.react.js
349–352 ↗	(On Diff #11558)	Used `Object.freeze()` where it was used initially and ran into flow issues when I removed it: We should either always freeze or never. Updating this diff to "freeze" everywhere.

Object.freeze() everywhere

Harbormaster completed remote builds in B8332: Diff 11641.Apr 19 2022, 2:44 PM

Closed by commit rCOMM5c826a4f1daa: [web] Move `queuedChanges` state up from `ThreadSettingsModal` to… (authored by atul). · Explain WhyApr 19 2022, 2:49 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM5c826a4f1daa: [web] Move `queuedChanges` state up from `ThreadSettingsModal` to….

Revision Contents
Changeset List

Path

Size

web/

modals/

threads/

thread-settings-modal.react.js

80 lines

Diff 11642

web/modals/threads/thread-settings-modal.react.js

Loading...