Page MenuHomePhabricator

benschac (Benjamin Schachter)
DisabledAdministrator

Projects

User does not belong to any projects.

User Details

User Since
Sep 18 2021, 4:45 PM (134 w, 20 h)
Roles
Administrator, Disabled

Recent Activity

May 27 2022

benschac closed D4058: [web, lib] [refactor] [ENG-536] move clear query to lib/hooks.
May 27 2022, 11:56 AM
benschac committed rCOMM50a152a78c58: [web, lib] [refactor] [ENG-536] move clear query to lib/hooks (authored by benschac).
[web, lib] [refactor] [ENG-536] move clear query to lib/hooks
May 27 2022, 11:56 AM
benschac updated the diff for D4058: [web, lib] [refactor] [ENG-536] move clear query to lib/hooks.

rename variable

May 27 2022, 11:52 AM
benschac updated the diff for D4058: [web, lib] [refactor] [ENG-536] move clear query to lib/hooks.

fix merge conflicts

May 27 2022, 11:37 AM
benschac closed D4143: [native] [fix] [ENG-1199] fix crashing app.
May 27 2022, 10:15 AM
benschac committed rCOMM6a7e80a1d313: [native] [fix] [ENG-1199] fix crashing app (authored by benschac).
[native] [fix] [ENG-1199] fix crashing app
May 27 2022, 10:15 AM
benschac added a comment to D4143: [native] [fix] [ENG-1199] fix crashing app.

I still need to look into this more. I'm not 100% why this code was ever needed in the first place. I do understand why it's causing and how it's causing a bug, just why this code is in the codebase in the first place.

May 27 2022, 10:14 AM
benschac updated the diff for D4143: [native] [fix] [ENG-1199] fix crashing app.

rebase

May 27 2022, 10:08 AM

May 26 2022

benschac updated subscribers of D4115: [native] [feat] [ENG-530] add icon to inline engagement.

Ignore me, I was confused. What's going on in the screenshot is a bunch of text is in the ChatInputBar and the user is swiping an earlier message. It seemed to me like something was being cut off accidentally, but I think it's intentional. The only part I'm still worried about is the orange line behind the "4 replies" button, but I assume that's just a visual side effect of the inspector?

Figma has the icon flipped the other way, which doesn't seem consistent.

I agree – I don't think we need to flip this, this diff looks good as-is.

May 26 2022, 12:37 PM
benschac requested review of D4115: [native] [feat] [ENG-530] add icon to inline engagement.

marking as request review to get this diff back in Ashoat's queue.

May 26 2022, 6:29 AM
benschac added a comment to D4115: [native] [feat] [ENG-530] add icon to inline engagement.

Screenshot looks super borked

May 26 2022, 6:28 AM

May 25 2022

benschac closed D4057: [lib, native, web] move onChangeSearch to hook.
May 25 2022, 12:00 PM
benschac committed rCOMMe0b2f89460b0: [lib, native, web] move onChangeSearch to hook (authored by benschac).
[lib, native, web] move onChangeSearch to hook
May 25 2022, 12:00 PM
benschac planned changes to D4060: [native, lib, web] [refactor] move text out of state.
May 25 2022, 11:23 AM
benschac updated the diff for D4060: [native, lib, web] [refactor] move text out of state.

local changes

May 25 2022, 11:23 AM
benschac added inline comments to D4057: [lib, native, web] move onChangeSearch to hook.
May 25 2022, 11:03 AM
benschac added inline comments to D4057: [lib, native, web] move onChangeSearch to hook.
May 25 2022, 10:59 AM
benschac requested review of D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component.

Answered questions, asking for review again to get this back in @ashoat's queue.

May 25 2022, 9:42 AM

May 24 2022

benschac updated the diff for D4057: [lib, native, web] move onChangeSearch to hook.

address atul's comment change onChangeSearchText -> onChangeSearchInputText

May 24 2022, 12:03 PM
benschac updated the diff for D4057: [lib, native, web] move onChangeSearch to hook.

readd changes that were lost

May 24 2022, 11:53 AM
benschac requested review of D4122: [web] [feat] [ENG-536] style sidebars modal.
May 24 2022, 11:13 AM
benschac updated the diff for D4067: [web, lib, native] [refactor] [ENG-536] rename listData to sidebar.

rebase

May 24 2022, 10:27 AM
benschac planned changes to D4066: [web] [refactor] [ENG-536] remove old sidebar styling from side bar modal.
May 24 2022, 10:26 AM
benschac updated the diff for D4066: [web] [refactor] [ENG-536] remove old sidebar styling from side bar modal.

rebase

May 24 2022, 10:25 AM
benschac planned changes to D4061: [lib, web] [feat] [ENG-536] hook up sidebar data to search modal.
May 24 2022, 10:25 AM
benschac updated the diff for D4061: [lib, web] [feat] [ENG-536] hook up sidebar data to search modal.

rebase

May 24 2022, 10:24 AM
benschac planned changes to D4060: [native, lib, web] [refactor] move text out of state.
May 24 2022, 10:24 AM
benschac updated the diff for D4060: [native, lib, web] [refactor] move text out of state.

rebase

May 24 2022, 10:24 AM
benschac updated the diff for D4058: [web, lib] [refactor] [ENG-536] move clear query to lib/hooks.

rebase

May 24 2022, 10:23 AM
benschac planned changes to D4057: [lib, native, web] move onChangeSearch to hook.
May 24 2022, 10:23 AM
benschac updated the diff for D4057: [lib, native, web] move onChangeSearch to hook.

rebase

May 24 2022, 10:22 AM
benschac requested review of D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component.

Marking this as needs review so it gets back into @ashoat review queue. No code update but replied to question.

May 24 2022, 9:43 AM
benschac added inline comments to D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component.
May 24 2022, 9:43 AM
benschac added inline comments to D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component.
May 24 2022, 9:42 AM
benschac published D4115: [native] [feat] [ENG-530] add icon to inline engagement for review.
May 24 2022, 7:56 AM
benschac requested review of D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component.

updated screen shots.

May 24 2022, 7:26 AM
benschac updated the summary of D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component.
May 24 2022, 7:26 AM
benschac updated the summary of D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component.
May 24 2022, 7:24 AM
benschac added a comment to D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component.

Just to be 100% sure the latest changes are correct:

May 24 2022, 7:07 AM
benschac updated the diff for D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component.

fix colors

May 24 2022, 7:03 AM

May 23 2022

benschac added a comment to D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component.

I imported the wrong color via the light theme. I'll come back and fix this tomorrow.

May 23 2022, 2:18 PM
benschac requested review of D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component.
May 23 2022, 12:10 PM
benschac added a comment to D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component.

Going to put this back in your queue since I've answered your questions, but didn't make code changes.

May 23 2022, 12:09 PM
benschac added a comment to D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component.

Yeah, this does look like close to right!

  1. Can you also link the Figma so we can compare / contrast?
  2. The color looks off to me... what do you think? Is this what was in the Figma? Maybe I just feel that way since the emojis aren't there yet, but it feels a bit off... also curious for @atul's perspective
May 23 2022, 12:08 PM
benschac requested review of D3537: [web] [fix] ENG-761 add padding between timestamp and message.

adding request review so it's in your queue ashoat.

May 23 2022, 11:58 AM
benschac added a comment to D3537: [web] [fix] ENG-761 add padding between timestamp and message.

Screen Shot 2022-05-23 at 2.55.53 PM.png (248×480 px, 57 KB)

May 23 2022, 11:58 AM
benschac added a comment to D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component.

Additionally, updated the screenshots to reflect the removal of D3998 (chat bubble design changes).

May 23 2022, 11:40 AM
benschac updated the summary of D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component.
May 23 2022, 11:38 AM
benschac updated the diff for D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component.

move the inline engagement bar a bit to make more space.

May 23 2022, 11:31 AM
benschac retitled D4001: [native] [feat] [ENG-530] add new styles to inline sidebar component from [native] [feat] [ENG-530] add new styles it inline sidebar component to [native] [feat] [ENG-530] add new styles to inline sidebar component.
May 23 2022, 11:17 AM
benschac abandoned D3998: [native] [fix] [ENG-1123] update message chat bubble design to match design (more padding and line height).
May 23 2022, 11:12 AM
benschac added a comment to D3998: [native] [fix] [ENG-1123] update message chat bubble design to match design (more padding and line height).

See here for some additional notes, basically making the chat bubbles look more like the Figma is a non-goal

May 23 2022, 11:05 AM
benschac requested review of D3537: [web] [fix] ENG-761 add padding between timestamp and message.
May 23 2022, 9:39 AM
benschac added a comment to D3537: [web] [fix] ENG-761 add padding between timestamp and message.
In D3537#97513, @ashoat wrote:

Can you modify the test plan so that it includes a table comparing padding/margin on all MessageList items between native / web? You can pull these numbers directly from the code, or use something like the React Native "Inspector" from the debug menu

May 23 2022, 9:39 AM
benschac updated the test plan for D3537: [web] [fix] ENG-761 add padding between timestamp and message.
May 23 2022, 9:38 AM

May 19 2022

benschac added a comment to D4057: [lib, native, web] move onChangeSearch to hook.

Took a stab at fixing the comment above. I removed @ashoat as a reviewer since he requested @atul confirm my change and made the blocking review @atul.

May 19 2022, 12:53 PM
benschac removed a reviewer for D4057: [lib, native, web] move onChangeSearch to hook: ashoat. benschac added 1 blocking reviewer(s) for D4057: [lib, native, web] move onChangeSearch to hook: atul.
May 19 2022, 12:52 PM
benschac updated the diff for D4057: [lib, native, web] move onChangeSearch to hook.

address diff feedback

May 19 2022, 12:51 PM
benschac closed D4056: [native, web, lib] [refactor] [ENG-536] move search index to hook.
May 19 2022, 12:40 PM
benschac committed rCOMM6205a4947c09: [native, web, lib] [refactor] [ENG-536] move search index to hook (authored by benschac).
[native, web, lib] [refactor] [ENG-536] move search index to hook
May 19 2022, 12:40 PM
benschac closed D4022: [native, lib, web] move search sidebar functionality to lib hooks.
May 19 2022, 12:36 PM
benschac committed rCOMM4635612d06ef: [native, lib, web] move search sidebar functionality to lib hooks (authored by benschac).
[native, lib, web] move search sidebar functionality to lib hooks
May 19 2022, 12:36 PM

May 17 2022

benschac updated the diff for D4067: [web, lib, native] [refactor] [ENG-536] rename listData to sidebar.

change variable name from item to sidebar

May 17 2022, 11:48 AM
benschac requested review of D4067: [web, lib, native] [refactor] [ENG-536] rename listData to sidebar.
May 17 2022, 11:23 AM
benschac added inline comments to D4022: [native, lib, web] move search sidebar functionality to lib hooks.
May 17 2022, 11:19 AM
benschac requested review of D4066: [web] [refactor] [ENG-536] remove old sidebar styling from side bar modal.
May 17 2022, 11:08 AM
benschac requested review of D3537: [web] [fix] ENG-761 add padding between timestamp and message.
In D3537#97513, @ashoat wrote:

Can you modify the test plan so that it includes a table comparing padding/margin on all MessageList items between native / web? You can pull these numbers directly from the code, or use something like the React Native "Inspector" from the debug menu

May 17 2022, 8:37 AM
benschac updated the test plan for D3537: [web] [fix] ENG-761 add padding between timestamp and message.
May 17 2022, 8:36 AM
benschac updated the test plan for D3537: [web] [fix] ENG-761 add padding between timestamp and message.
May 17 2022, 8:35 AM
benschac updated the test plan for D3537: [web] [fix] ENG-761 add padding between timestamp and message.
May 17 2022, 8:34 AM
benschac updated the test plan for D3537: [web] [fix] ENG-761 add padding between timestamp and message.
May 17 2022, 8:34 AM
benschac updated the diff for D4061: [lib, web] [feat] [ENG-536] hook up sidebar data to search modal.

rebase

May 17 2022, 8:02 AM
benschac updated the diff for D4060: [native, lib, web] [refactor] move text out of state.

rebase

May 17 2022, 8:02 AM
benschac updated the diff for D4058: [web, lib] [refactor] [ENG-536] move clear query to lib/hooks.

rebase

May 17 2022, 8:02 AM
benschac updated the diff for D4057: [lib, native, web] move onChangeSearch to hook.

rebase

May 17 2022, 8:02 AM
benschac updated the diff for D4056: [native, web, lib] [refactor] [ENG-536] move search index to hook.

rebase

May 17 2022, 8:02 AM
benschac updated the diff for D4022: [native, lib, web] move search sidebar functionality to lib hooks.

rebase

May 17 2022, 8:02 AM
benschac updated the diff for D4058: [web, lib] [refactor] [ENG-536] move clear query to lib/hooks.

add plus

May 17 2022, 8:00 AM
benschac added inline comments to D4058: [web, lib] [refactor] [ENG-536] move clear query to lib/hooks.
May 17 2022, 7:59 AM
benschac updated the diff for D4061: [lib, web] [feat] [ENG-536] hook up sidebar data to search modal.

rebase

May 17 2022, 7:57 AM
benschac updated the diff for D4060: [native, lib, web] [refactor] move text out of state.

rebase

May 17 2022, 7:57 AM
benschac updated the diff for D4058: [web, lib] [refactor] [ENG-536] move clear query to lib/hooks.

rebase

May 17 2022, 7:57 AM
benschac updated the diff for D4057: [lib, native, web] move onChangeSearch to hook.

rebase

May 17 2022, 7:57 AM
benschac updated the diff for D4056: [native, web, lib] [refactor] [ENG-536] move search index to hook.

rebase

May 17 2022, 7:57 AM
benschac updated the diff for D4022: [native, lib, web] move search sidebar functionality to lib hooks.

rebase

May 17 2022, 7:56 AM
benschac updated the diff for D4022: [native, lib, web] move search sidebar functionality to lib hooks.

add readonly types

May 17 2022, 6:18 AM

May 16 2022

benschac updated the summary of D4060: [native, lib, web] [refactor] move text out of state.
May 16 2022, 3:04 PM
benschac updated the summary of D4061: [lib, web] [feat] [ENG-536] hook up sidebar data to search modal.
May 16 2022, 3:03 PM
benschac added inline comments to D4060: [native, lib, web] [refactor] move text out of state.
May 16 2022, 2:37 PM
benschac requested review of D4061: [lib, web] [feat] [ENG-536] hook up sidebar data to search modal.
May 16 2022, 2:37 PM
benschac requested review of D4060: [native, lib, web] [refactor] move text out of state.
May 16 2022, 2:33 PM
benschac updated the diff for D4058: [web, lib] [refactor] [ENG-536] move clear query to lib/hooks.

rebase

May 16 2022, 2:21 PM
benschac updated the diff for D4057: [lib, native, web] move onChangeSearch to hook.

rebase

May 16 2022, 2:21 PM
benschac updated the diff for D4056: [native, web, lib] [refactor] [ENG-536] move search index to hook.

rebase

May 16 2022, 2:21 PM
benschac updated the diff for D4022: [native, lib, web] move search sidebar functionality to lib hooks.

rebase

May 16 2022, 2:20 PM
benschac requested review of D4058: [web, lib] [refactor] [ENG-536] move clear query to lib/hooks.
May 16 2022, 8:41 AM
benschac requested review of D4057: [lib, native, web] move onChangeSearch to hook.
May 16 2022, 8:12 AM
benschac requested review of D4056: [native, web, lib] [refactor] [ENG-536] move search index to hook.
May 16 2022, 8:11 AM
benschac updated the diff for D4022: [native, lib, web] move search sidebar functionality to lib hooks.

add read only

May 16 2022, 8:11 AM
benschac updated the diff for D4022: [native, lib, web] move search sidebar functionality to lib hooks.

rebase

May 16 2022, 8:04 AM