rename variable

fix merge conflicts

I still need to look into this more. I'm not 100% why this code was ever needed in the first place. I do understand why it's causing and how it's causing a bug, just why this code is in the codebase in the first place.

rebase

In D4115#116975, @ashoat wrote:

Ignore me, I was confused. What's going on in the screenshot is a bunch of text is in the ChatInputBar and the user is swiping an earlier message. It seemed to me like something was being cut off accidentally, but I think it's intentional. The only part I'm still worried about is the orange line behind the "4 replies" button, but I assume that's just a visual side effect of the inspector?

Figma has the icon flipped the other way, which doesn't seem consistent.

I agree – I don't think we need to flip this, this diff looks good as-is.

marking as request review to get this diff back in Ashoat's queue.

In D4115#116487, @ashoat wrote:

Screenshot looks super borked

local changes

Answered questions, asking for review again to get this back in @ashoat's queue.

address atul's comment change onChangeSearchText -> onChangeSearchInputText

readd changes that were lost

rebase

rebase

rebase

rebase

rebase

rebase

Marking this as needs review so it gets back into @ashoat review queue. No code update but replied to question.

updated screen shots.

Just to be 100% sure the latest changes are correct:

fix colors

I imported the wrong color via the light theme. I'll come back and fix this tomorrow.

Going to put this back in your queue since I've answered your questions, but didn't make code changes.

In D4001#115883, @ashoat wrote:

Yeah, this does look like close to right!

1. Can you also link the Figma so we can compare / contrast?
2. The color looks off to me... what do you think? Is this what was in the Figma? Maybe I just feel that way since the emojis aren't there yet, but it feels a bit off... also curious for @atul's perspective

adding request review so it's in your queue ashoat.

In D3537#115886, @ashoat wrote:

Additionally, updated the screenshots to reflect the removal of D3998 (chat bubble design changes).

move the inline engagement bar a bit to make more space.

In D3998#112430, @ashoat wrote:

See here for some additional notes, basically making the chat bubbles look more like the Figma is a non-goal

In D3537#97513, @ashoat wrote:

Can you modify the test plan so that it includes a table comparing padding/margin on all MessageList items between native / web? You can pull these numbers directly from the code, or use something like the React Native "Inspector" from the debug menu

Took a stab at fixing the comment above. I removed @ashoat as a reviewer since he requested @atul confirm my change and made the blocking review @atul.

address diff feedback

change variable name from item to sidebar

In D3537#97513, @ashoat wrote:

Can you modify the test plan so that it includes a table comparing padding/margin on all MessageList items between native / web? You can pull these numbers directly from the code, or use something like the React Native "Inspector" from the debug menu

rebase

rebase

rebase

rebase

rebase

rebase

add plus

rebase

rebase

rebase

rebase

rebase

rebase

add readonly types

rebase

rebase

rebase

rebase

add read only

rebase