Paths

Table of Contentst

Differential D4067

[web, lib, native] [refactor] [ENG-536] rename listData to sidebar
AbandonedPublic
Actions

Authored by tomek on May 17 2022, 11:18 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Mon, Apr 22, 12:04 PM

	Unknown Object (File)
	Mon, Apr 22, 9:04 AM

	Unknown Object (File)
	Fri, Apr 19, 6:12 PM

	Unknown Object (File)
	Fri, Apr 19, 6:12 PM

	Unknown Object (File)
	Fri, Apr 19, 6:12 PM

	Unknown Object (File)
	Fri, Apr 19, 6:12 PM

	Unknown Object (File)
	Fri, Apr 19, 6:05 PM

	Unknown Object (File)
	Fri, Apr 5, 5:23 PM

Subscribers

Details

Reviewers

atul
• jacek
• benschac

Summary

rename listData to sidebars

Test Plan

N/A just a better namee

Diff Detail

Repository

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.May 17 2022, 11:18 AM

Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 17 2022, 11:18 AM

• benschac added a parent revision: D4066: [web] [refactor] [ENG-536] remove old sidebar styling from side bar modal.May 17 2022, 11:18 AM

• benschac mentioned this in D4022: [native, lib, web] move search sidebar functionality to lib hooks.

Harbormaster completed remote builds in B9237: Diff 12831.May 17 2022, 11:23 AM

• benschac requested review of this revision.May 17 2022, 11:23 AM

change variable name from item to sidebar

Harbormaster completed remote builds in B9239: Diff 12834.May 17 2022, 11:56 AM

N/A just a better namee

You ran the flow, right? - that's the most basic test plan here.

web/modals/chat/sidebar-list-modal.react.js
29–33 ↗	(On Diff #12834)	It's `sidebar`! Please be consistent with naming.

This revision is now accepted and ready to land.May 19 2022, 1:38 AM

ashoat added inline comments.May 19 2022, 12:32 PM

web/modals/chat/sidebar-list-modal.react.js
29–33 ↗	(On Diff #12834)	@benschac please make sure to address this before landing

rebase

• benschac added a child revision: D4122: [web] [feat] [ENG-536] style sidebars modal.May 24 2022, 10:30 AM

Harbormaster completed remote builds in B9456: Diff 13094.May 24 2022, 11:05 AM

ashoat mentioned this in D4122: [web] [feat] [ENG-536] style sidebars modal.May 24 2022, 12:31 PM

tomek commandeered this revision.Wed, Apr 3, 2:36 AM

tomek edited reviewers, added: • benschac; removed: tomek.

This revision now requires review to proceed.Wed, Apr 3, 2:36 AM

The task from the title https://linear.app/comm/issue/ENG-536/sidebar-list-modal-re-style - is marked as done. If we decide to do something more about that issue, it would be probably easier to do it from scratch instead of figuring out how to make this stack solve the problem.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

search-sidebars.js

8 lines

native/

chat/

sidebar-list-modal.react.js

4 lines

web/

modals/

chat/

sidebar-list-modal.react.js

8 lines

Diff 13094

lib/hooks/search-sidebars.js

Loading...

native/chat/sidebar-list-modal.react.js

Loading...

web/modals/chat/sidebar-list-modal.react.js

Loading...