Page MenuHomePhabricator

[web] [feat] [ENG-536] style sidebars modal
AbandonedPublic

Authored by benschac on May 24 2022, 10:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Feb 27, 4:29 PM
Unknown Object (File)
Tue, Feb 27, 6:33 AM
Unknown Object (File)
Tue, Feb 27, 6:32 AM
Unknown Object (File)
Tue, Feb 27, 6:32 AM
Unknown Object (File)
Feb 21 2024, 10:16 PM
Unknown Object (File)
Feb 21 2024, 5:02 PM
Unknown Object (File)
Feb 21 2024, 6:49 AM
Unknown Object (File)
Feb 18 2024, 3:52 AM

Details

Reviewers
tomek
ashoat
atul
Summary

add basic styling to the sidebars modal

Test Plan

will add screen shots, there isn't design for this screen. I'll get feedback from @ashoat

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ashoat requested changes to this revision.May 24 2022, 12:31 PM

Please attach screenshots before requesting review

web/chat/sidebar-modal-item.react.js
16

"Sidebar" is one word. @palys-swm gave you this feedback in D4066 and D4067, and it hasn't been addressed in either, so I'm a bit worried that you missed it. Requesting changes to make sure you grok this feedback and internalize it, so it doesn't have to be repeated again

This revision now requires changes to proceed.May 24 2022, 12:31 PM
atul edited reviewers, added: benschac; removed: atul.
atul added a subscriber: jacek.

@jacek I believe you handled this separately? It looks fine on prod.

atul foisted this revision upon benschac.
atul edited reviewers, added: atul; removed: benschac.