Page MenuHomePhabricator

[web] [refactor] [ENG-536] remove old sidebar styling from side bar modal
Changes PlannedPublic

Authored by benschac on May 17 2022, 10:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 18, 2:01 AM
Unknown Object (File)
Fri, Mar 15, 3:16 AM
Unknown Object (File)
Wed, Mar 13, 3:17 AM
Unknown Object (File)
Feb 21 2024, 11:10 PM
Unknown Object (File)
Feb 21 2024, 9:26 PM
Unknown Object (File)
Feb 21 2024, 8:39 PM
Unknown Object (File)
Feb 21 2024, 8:21 PM
Unknown Object (File)
Feb 21 2024, 7:05 AM

Details

Summary

Remove old styles. I think the modal sidebar items will look a little different than what's on web. Additionally, the sidebar styles in the ChatTheadList are very hard coded to the sidebar

Test Plan

N/A. Nothing really changes visually here. Just getting rid of old styles

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek requested changes to this revision.May 19 2022, 1:35 AM

remove old sidebar styling from side bar modal

Sidebar is a single word

I think the modal sidebar items will look a little different than what's on web.

I don't understand. Do you mean that the sidebars in search modal look different from the ones on the thread list? Please be clearer when writing a summary!

Additionally, the sidebar styles in the ChatTheadList are very hard coded to the sidebar

What's the conclusion?

N/A. Nothing really changes visually here. Just getting rid of old styles

If nothing changes visually, the test plan should verify that!

This revision now requires changes to proceed.May 19 2022, 1:35 AM