Page MenuHomePhabricator

[web] [refactor] [ENG-536] remove old sidebar styling from side bar modal
AbandonedPublic

Authored by tomek on May 17 2022, 10:57 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 6:12 PM
Unknown Object (File)
Fri, Apr 19, 6:12 PM
Unknown Object (File)
Fri, Apr 19, 6:12 PM
Unknown Object (File)
Fri, Apr 19, 6:12 PM
Unknown Object (File)
Fri, Apr 19, 6:05 PM
Unknown Object (File)
Wed, Apr 17, 6:36 PM
Unknown Object (File)
Thu, Apr 11, 5:05 PM
Unknown Object (File)
Tue, Apr 9, 12:57 PM

Details

Summary

Remove old styles. I think the modal sidebar items will look a little different than what's on web. Additionally, the sidebar styles in the ChatTheadList are very hard coded to the sidebar

Test Plan

N/A. Nothing really changes visually here. Just getting rid of old styles

Diff Detail

Repository
rCOMM Comm
Branch
side-bar-list-modal-ENG-536
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek requested changes to this revision.May 19 2022, 1:35 AM

remove old sidebar styling from side bar modal

Sidebar is a single word

I think the modal sidebar items will look a little different than what's on web.

I don't understand. Do you mean that the sidebars in search modal look different from the ones on the thread list? Please be clearer when writing a summary!

Additionally, the sidebar styles in the ChatTheadList are very hard coded to the sidebar

What's the conclusion?

N/A. Nothing really changes visually here. Just getting rid of old styles

If nothing changes visually, the test plan should verify that!

This revision now requires changes to proceed.May 19 2022, 1:35 AM
tomek abandoned this revision.
tomek edited reviewers, added: benschac; removed: tomek.

The task from the title https://linear.app/comm/issue/ENG-536/sidebar-list-modal-re-style - is marked as done. If we decide to do something more about that issue, it would be probably easier to do it from scratch instead of figuring out how to make this stack solve the problem.