Page MenuHomePhabricator
Differential D4056

[native, web, lib] [refactor] [ENG-536] move search index to hook
ClosedPublic
Actions

Authored by • benschac on May 16 2022, 8:05 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 2, 2:51 AM
Unknown Object (File)
Tue, Apr 1, 8:54 AM
Unknown Object (File)
Sun, Mar 30, 9:04 PM
Unknown Object (File)
Sun, Mar 30, 1:03 PM
Unknown Object (File)
Fri, Mar 21, 10:16 AM
Unknown Object (File)
Wed, Mar 19, 9:44 PM
Unknown Object (File)
Wed, Mar 19, 1:09 PM
Unknown Object (File)
Sat, Mar 15, 6:06 PM
View All Files
Subscribers
• abosh
• adrian
ashoat

Details

Reviewers
atul
tomek
• jacek
Commits
rCOMM6205a4947c09: [native, web, lib] [refactor] [ENG-536] move search index to hook
Summary

moves the search index code that's used in both native and web into lib/hooks

Test Plan

test sidebar search functionality in both native/ and web they should both work as expected.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

• benschac created this revision.May 16 2022, 8:05 AM
Herald added subscribers: • abosh, • adrian, ashoat. · View Herald TranscriptMay 16 2022, 8:05 AM
• benschac added a parent revision: D4022: [native, lib, web] move search sidebar functionality to lib hooks.May 16 2022, 8:06 AM
• benschac added a child revision: D4057: [lib, native, web] move onChangeSearch to hook.
Harbormaster completed remote builds in B9165: Diff 12744.May 16 2022, 8:11 AM
• benschac requested review of this revision.May 16 2022, 8:11 AM
• benschac updated this revision to Diff 12772.May 16 2022, 2:21 PM

rebase

Harbormaster completed remote builds in B9181: Diff 12772.May 16 2022, 2:26 PM
• benschac updated this revision to Diff 12815.May 17 2022, 7:57 AM

rebase

Harbormaster failed remote builds in B9222: Diff 12815!May 17 2022, 8:01 AM
• benschac updated this revision to Diff 12822.May 17 2022, 8:02 AM

rebase

Harbormaster failed remote builds in B9229: Diff 12822!May 17 2022, 8:02 AM
Harbormaster completed remote builds in B9222: Diff 12815.May 17 2022, 8:34 AM
Harbormaster completed remote builds in B9229: Diff 12822.May 17 2022, 8:47 AM
tomek accepted this revision.May 18 2022, 3:26 AM
This revision is now accepted and ready to land.May 18 2022, 3:26 AM
Closed by commit rCOMM6205a4947c09: [native, web, lib] [refactor] [ENG-536] move search index to hook (authored by • benschac). · Explain WhyMay 19 2022, 12:40 PM
This revision was automatically updated to reflect the committed changes.
• benschac added a commit: rCOMM6205a4947c09: [native, web, lib] [refactor] [ENG-536] move search index to hook.

Revision Contents
Changeset List

PathSize
lib/
hooks/
36 lines
native/
chat/
39 lines
web/
modals/
chat/
40 lines

Diff 12970

View Options

lib/hooks/search-sidebars.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines
View Options

native/chat/sidebar-list-modal.react.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines
View Options

web/modals/chat/sidebar-list-modal.react.js

Show All 21 Lines
a { a {
text-decoration: none; text-decoration: none;
color: #2a5db0; color: #2a5db0;
} }
img, img,
iframe { iframe {
display: block; display: block;
} }
input[type='text'], input[type='text'],
input[type='password'], input[type='password'],
textarea { textarea {
atulUnsubmitted
Not Done
Inline Actions

Moving the global input styling and moving it to the input component.

Then why are we keeping styles like border and border-radius?

Don't these styles also affect the <textarea> tag? Are you sure we want to be removing these styles for that as well? Or should we break this into two separate selectors (one for input and another for textarea)?

atul: > Moving the global input styling and moving it to the input component. Then why are we…
benschacAuthorUnsubmitted
Done
Inline Actions

Yeah, I should break these styles out a bit more. I don't think they really do anything. But you make a good point that this will also effect textarea elements.

benschac: Yeah, I should break these styles out a bit more. I don't think they really do anything. But…
-webkit-appearance: none;
-moz-appearance: none;
-webkit-border-radius: 0;
border: 1px solid #dddddd; border: 1px solid #dddddd;
border-radius: 1px; border-radius: 1px;
font-family: var(--font-stack); font-family: var(--font-stack);
} }
:global(#react-root) { :global(#react-root) {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
height: 100%; height: 100%;
▲ Show 20 Lines • Show All 243 Lines • Show Last 20 Lines