The application is currently in a broken state. If you open the see more sidebar modal then close the app, open the app the app will stay in a loading state indefinitely. Adding @ashoat since this is a pretty urgent issue that needs to be fixed ASAP.
Details
Details
try the above locally to confirm app is broken. Patch this diff and try the same steps again, the app should load as expected. Additionally, try search sidebars functionality to make sure it's still working as expected.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
I still need to look into this more. I'm not 100% why this code was ever needed in the first place. I do understand why it's causing and how it's causing a bug, just why this code is in the codebase in the first place.
I've tested this change both on native and web. Search sidebar functionality works as expected.
Comment Actions
I think the idea is that if the searchIndex changes (eg. if one of the potential search results changes), then we should recalculate the results