Page MenuHomePhabricator

[native] [feat] [ENG-530] add icon to inline engagement
AbandonedPublic

Authored by benschac on May 24 2022, 7:46 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 14, 4:38 PM
Unknown Object (File)
Wed, Nov 13, 10:52 AM
Unknown Object (File)
Fri, Nov 8, 11:25 PM
Unknown Object (File)
Mon, Oct 28, 7:32 AM
Unknown Object (File)
Oct 19 2024, 9:48 PM
Unknown Object (File)
Oct 19 2024, 1:19 PM
Unknown Object (File)
Oct 19 2024, 1:19 PM
Unknown Object (File)
Oct 19 2024, 1:08 PM

Details

Summary

Add reply icon to inline engagement component https://www.figma.com/file/L675ETKDnGaSwlpZAw4MIC/Mobile-App?node-id=344%3A491

What's currently implement. I think this makes sense.

Simulator Screen Shot - iPhone 13 mini - 2022-05-24 at 10.51.48.png (2×1 px, 563 KB)

Figma has the icon flipped the other way which doesn't seem consistent.

CleanShot 2022-05-24 at 10.52.32@2x.png (524×734 px, 44 KB)

Adding @ashoat as a blocking review since I'm diverging from the design a bit.

Test Plan

should match figma, there is a bit of design inconstancy between figma and the actual design which is shown in the screen shot

Diff Detail

Repository
rCOMM Comm
Branch
inline-sidebar-web-and-native-ENG-530
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

benschac held this revision as a draft.
benschac added 1 blocking reviewer(s): ashoat.
ashoat requested changes to this revision.May 24 2022, 12:24 PM

Screenshot looks super borked

This revision now requires changes to proceed.May 24 2022, 12:24 PM

Screenshot looks super borked

Could you give me a little more context?
Are you noting the inspector being open? Or the little line from the animation sliding that sometimes happens on the simulator?

Any additional context to help me solve the problem you're seeing would be extremely helpful. Just telling me it looks borked does nothing to help me fix the problem you're seeing.

Additionally, could you answer the design question that I initially asked:

Figma has the icon flipped the other way, which doesn't seem consistent.

I'm assuming we don't want to invert the icon on the inline engagement component because that would be inconsistent with what's in the swappable-message.react.js

marking as request review to get this diff back in Ashoat's queue.

Ignore me, I was confused. What's going on in the screenshot is a bunch of text is in the ChatInputBar and the user is swiping an earlier message. It seemed to me like something was being cut off accidentally, but I think it's intentional. The only part I'm still worried about is the orange line behind the "4 replies" button, but I assume that's just a visual side effect of the inspector?

Figma has the icon flipped the other way, which doesn't seem consistent.

I agree – I don't think we need to flip this, this diff looks good as-is.

Any additional context to help me solve the problem you're seeing would be extremely helpful. Just telling me it looks borked does nothing to help me fix the problem you're seeing.

This is my bad – I'll try to communicate better next time.

Or the little line from the animation sliding that sometimes happens on the simulator?

Yeah, this is weird... can you clarify if it's just the inspector?

Ignore me, I was confused. What's going on in the screenshot is a bunch of text is in the ChatInputBar and the user is swiping an earlier message. It seemed to me like something was being cut off accidentally, but I think it's intentional. The only part I'm still worried about is the orange line behind the "4 replies" button, but I assume that's just a visual side effect of the inspector?

Figma has the icon flipped the other way, which doesn't seem consistent.

I agree – I don't think we need to flip this, this diff looks good as-is.

Awesome!

Any additional context to help me solve the problem you're seeing would be extremely helpful. Just telling me it looks borked does nothing to help me fix the problem you're seeing.

This is my bad – I'll try to communicate better next time.

Np! Happens sometimes.

Or the little line from the animation sliding that sometimes happens on the simulator?

Yeah, this is weird... can you clarify if it's just the inspector?
but I assume that's just a visual side effect of the inspector?

Yeah, this has always happened to me when taking a screenshot with the simulator and animating something.

This revision is now accepted and ready to land.May 27 2022, 5:35 AM
atul abandoned this revision.
atul edited reviewers, added: benschac; removed: atul.

(Copied from D3893)

@jacek I think we can abandon these changes since you've started a separate stack to deal with InlineSidebar. Let me know if I'm mistaken and I can re-open this if it tracks some unique work.

atul edited reviewers, added: atul; removed: benschac.