Paths

Table of Contentst

Differential D3915

[web,native,lib] [refactor] [ENG-530] rename hook to useInlineEngagement from useInlineText
AbandonedPublic
Actions

Authored by • benschac on May 4 2022, 9:00 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 21, 9:17 PM

	Unknown Object (File)
	Wed, Nov 27, 4:05 AM

	Unknown Object (File)
	Wed, Nov 27, 1:14 AM

	Unknown Object (File)
	Nov 18 2024, 7:24 PM

	Unknown Object (File)
	Nov 5 2024, 11:25 AM

	Unknown Object (File)
	Oct 28 2024, 3:04 AM

	Unknown Object (File)
	Oct 28 2024, 2:00 AM

	Unknown Object (File)
	Oct 28 2024, 1:56 AM

Subscribers

Details

Reviewers

ashoat
atul

Summary

from diff https://phabricator.ashoat.com/D3895 suggestion was made > In a later diff it would probably be good to rename InlineSidebar to InlineFeedback, InlineReactions, InlineResponses, or InlineEngagement or something. Requesting ashoat since he made the request.

Test Plan

feature still works as expected, naming of hook changed consistently across the codebase.

Diff Detail

Repository

Branch

inline-sidebar-web-and-native-ENG-530

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

• benschac created this revision.May 4 2022, 9:00 AM

Herald added subscribers: • abosh, • karol, • adrian, tomek. · View Herald TranscriptMay 4 2022, 9:00 AM

• benschac mentioned this in D3895: [web] [chore] [ENG-530] style inline sidebar.May 4 2022, 9:00 AM

• benschac added a parent revision: D3897: [native] [chore] [ENG-530] remove arrows from inline sidebar.

Harbormaster completed remote builds in B8779: Diff 12226.May 4 2022, 9:04 AM

• benschac requested review of this revision.May 4 2022, 9:04 AM

ashoat accepted this revision.May 4 2022, 11:12 AM

This revision is now accepted and ready to land.May 4 2022, 11:12 AM

(Assuming InlineSidebar gets renamed in a separate diff)

• benschac added a child revision: D3963: [native] [fix] [ENG-1099] fix hot reload compose component.May 6 2022, 1:47 PM

• benschac added a child revision: D3971: [refactor] [native] [ENG-530] Remove positioning prop from InlineSidebar component.May 9 2022, 10:34 AM

atul commandeered this revision.Aug 15 2022, 10:03 AM

atul abandoned this revision.

atul edited reviewers, added: • benschac; removed: atul.

atul foisted this revision upon • benschac.

atul edited reviewers, added: atul; removed: • benschac.

Revision Contents
Changeset List

Path

Size

lib/

hooks/

	inline-engagement-text.react.js
	inline-sidebar-text.react.js

4 lines

inline-sidebar-text.react.js

native/

chat/

inline-sidebar.react.js

4 lines

web/

chat/

inline-sidebar.react.js

4 lines

Diff 12226

lib/hooks/inline-engagement-text.react.js

Loading...

lib/hooks/inline-sidebar-text.react.js

Loading...

native/chat/inline-sidebar.react.js

Loading...

web/chat/inline-sidebar.react.js

Loading...